Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary 'become:true' #21

Merged
merged 2 commits into from
Aug 5, 2024
Merged

Remove unnecessary 'become:true' #21

merged 2 commits into from
Aug 5, 2024

Conversation

fghanmi
Copy link
Collaborator

@fghanmi fghanmi commented Aug 5, 2024

No description provided.

@bkabrda
Copy link
Collaborator

bkabrda commented Aug 5, 2024

Have you taken a look at roles/tas_single_node/tasks/main.yml? There are some become: true there that I think we could remove as well.

@fghanmi
Copy link
Collaborator Author

fghanmi commented Aug 5, 2024

Have you taken a look at roles/tas_single_node/tasks/main.yml? There are some become: true there that I think we could remove as well.

yes right,
This would require the user to always add ansible_become=true in the inventory.

@bkabrda
Copy link
Collaborator

bkabrda commented Aug 5, 2024

This would require the user to always add ansible_become=true in the inventory.

Yes, I think we should just mandate this. Most of our tasks will always require that anyway, so I think that shouldn't be a problem.

@fghanmi fghanmi requested a review from bkabrda August 5, 2024 09:19
@fghanmi fghanmi merged commit 1154e16 into main Aug 5, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants