Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update landing page layout and content #257

Merged
merged 13 commits into from
Jun 11, 2024

Conversation

signekb
Copy link
Member

@signekb signekb commented Jun 11, 2024

Description

  • This PR updates the layout and content of the landing page.
  • The layout follows Brainstorm better landing page layout for main website #239
  • I have rewritten the goals by putting two of the existing goals into one ("To create a framework for setting up an infrastructure for health data" and "To develop the framework as installable software") and adding a goal of "leading by example". What do you think?
  • I have also added a "definition" of a data resource to make it a bit clearer for new users what is meant there.
  • These changes are done to make the landing page more visually appealing and to update the content that users/visitors of the webpage meet first.

Related Issues

Closes #144 and #241

See also Issues #...

Reviewer Focus

This PR requires an in-depth review.

Checklist

For all PRs that are not general documentation

  • Tests accompany or reflect changes to the code
  • Tests ran and passed locally
  • Ran the linter and formatter
  • Build has passed locally
  • Relevant documentation has been updated

For general documentation:

  • Spell-check
  • Did the page(s) preview correctly on your machine without breaking
  • New category words (keywords) (if any) added to the code snippet file (none)

@signekb signekb marked this pull request as ready for review June 11, 2024 11:18
@signekb signekb requested a review from a team as a code owner June 11, 2024 11:18
Copy link
Member

@lwjohnst86 lwjohnst86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice! I've made some changes, like reduce amount of text and put the NNF logo and text into columns.

@lwjohnst86 lwjohnst86 merged commit 5502f80 into main Jun 11, 2024
@lwjohnst86 lwjohnst86 deleted the feat/update-landing-page-layout-and-content branch June 11, 2024 12:41
Comment on lines +93 to +95
:::::
::::::
:::::::
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks a bit crazy. @lwjohnst86 was this your formatter that did this?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same with L62 with seven colons?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know... I used the same VSCode formatter we've all been using, not sure why it did that and I didn't have time to look into it. It is weird for sure... I thought it was a mistake at first, so fixed it, than ran formatter again and it did it again 😠 💢

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Weird! Which formatter is this? I don't think it happens to me??

@signekb
Copy link
Member Author

signekb commented Jun 11, 2024

Nice with the shorter texts! 🎉

Comment on lines +66 to +67
::::: grid
::: g-col-8
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lwjohnst86 Why is this without {} in contrast to e.g., L29-30?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@signekb when only one class is provided, the formatter removes the {}. It's not me!! 😛

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very weird!

@signekb signekb mentioned this pull request Jun 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve front page (suggestions)
2 participants