-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: update landing page layout and content #257
feat: update landing page layout and content #257
Conversation
…ebsite into feat/update-landing-page-layout-and-content
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice! I've made some changes, like reduce amount of text and put the NNF logo and text into columns.
::::: | ||
:::::: | ||
::::::: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks a bit crazy. @lwjohnst86 was this your formatter that did this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same with L62 with seven colons?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know... I used the same VSCode formatter we've all been using, not sure why it did that and I didn't have time to look into it. It is weird for sure... I thought it was a mistake at first, so fixed it, than ran formatter again and it did it again 😠 💢
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Weird! Which formatter is this? I don't think it happens to me??
Nice with the shorter texts! 🎉 |
::::: grid | ||
::: g-col-8 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lwjohnst86 Why is this without {}
in contrast to e.g., L29-30?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@signekb when only one class is provided, the formatter removes the {}
. It's not me!! 😛
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very weird!
Description
Related Issues
Closes #144 and #241
See also Issues #...
Reviewer Focus
This PR requires an in-depth review.
Checklist
For all PRs that are not general documentation
For general documentation: