Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Upgrade go-sqlite3 to v1.14.22 (#142)
## Description Update the `go-sqlite3` dependency for Ctlstore to get to the latest upstream version from https://github.com/mattn/go-sqlite3. Notably we depend on a Segment-specific fork that includes a patch which enables preupdate hooks for our code without requiring a build-time flag to be manually put into place by all users of the ctlstore library. ## Details This depends on segmentio/go-sqlite3#9 to allow the `go get` to succeed. Once that is merged, we deleted the [segment-v1.14.22](https://github.com/segmentio/go-sqlite3/releases/tag/segment-v1.14.22) tag in that repo and recreated it as [v1.14.22-segment](https://github.com/segmentio/go-sqlite3/releases/tag/v1.14.22-segment). > [!TIP] > Despite fixing the `master` of go-sqlite3 to [update module path](https://github.com/segmentio/go-sqlite3/blob/b9c49a6eaf4ca03f2515c9ef9334d20741363b3b/go.mod#L1), I was getting errors doing `go get` after deleting and recreating the `segment-v1.14.22` tag like so: > ``` > % go get github.com/segmentio/[email protected] > go: github.com/segmentio/[email protected] (v1.14.23-0.20240208202956-73b5bef61db6) > requires github.com/segmentio/[email protected]: parsing go.mod: > module declares its path as: github.com/mattn/go-sqlite3 > but was required as: github.com/segmentio/go-sqlite3 > ``` > > @kevinburkesegment explained this was likely due to the Go package cache, so we decided to just delete that previous tag and not try to recreate it. Instead we created a tag with a different name. Testing completed successfully: * [x] ensure CI runs * [x] verify on other services that include ctlstore client, when those services are updated. https://segment.atlassian.net/browse/IO-1695 > [!NOTE] > Replacement for PR #140 which had the wrong version number in its branch name.
- Loading branch information
