Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include FAQ on unnamed events #5543

Merged
merged 2 commits into from
Oct 30, 2023
Merged

Include FAQ on unnamed events #5543

merged 2 commits into from
Oct 30, 2023

Conversation

bcaudillo
Copy link
Contributor

Proposed changes

Adding a portion to explain unnamed events in the breakdown table

Merge timing

Once approved

@bcaudillo bcaudillo added the KCS label Oct 17, 2023
@bcaudillo bcaudillo marked this pull request as ready for review October 25, 2023 17:17
@bcaudillo bcaudillo requested a review from a team as a code owner October 25, 2023 17:17
@bcaudillo bcaudillo requested review from stayseesong and removed request for a team October 25, 2023 17:17
@stayseesong
Copy link
Contributor

@bcaudillo I added the information about unnamed events in the section with the breakdown table as I think it makes more sense to put it there. lmk what you think

@bcaudillo
Copy link
Contributor Author

Hi @stayseesong I agree that seems like the better place for the snippet.

@stayseesong stayseesong merged commit 969c501 into develop Oct 30, 2023
@stayseesong stayseesong deleted the bcaudillo-patch-7 branch October 30, 2023 18:08
@github-actions
Copy link
Contributor

Thank you for your contribution! Your pull request is merged, but may take a day or two to appear on the site.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants