-
Notifications
You must be signed in to change notification settings - Fork 357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
move all insider dests out of beta and hide deprecated classic dest docs #5583
Conversation
@@ -3,5 +3,4 @@ title: 'Insider Audiences Destination' | |||
hidden: true | |||
id: 643698ffee21b544f6aa756a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hey @tcgilbert - looks like this page doesn't have any content other than the frontmatter/shares the same ID as the actions-insider-audiences
page. The docs point to the actions-insider-audiences
page for this destination (https://segment.com/docs/connections/destinations/catalog/actions-insider-audiences/) - I'll go ahead and delete this folder and the index file!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll open a new PR deleting the two "ghost" files. The rest of the PR looks good to me!
@@ -3,5 +3,4 @@ title: 'Insider Cloud Mode (Actions) Destination' | |||
hidden: true | |||
id: 643697f531f98a978f414453 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hey @tcgilbert - looks like this is a "ghost" page too: it has frontmatter but no content. Looks like the equivalent page is actions-insider-cloud
, which has the same ID as this page does. I'll look into why the catalog script does this!
ghost = files with frontmatter but no content & duplicate IDs to other files full of content (see #5583)
Thank you for your contribution! Your pull request is merged, but may take a day or two to appear on the site. |
Proposed changes
move all insider dests out of beta and hide deprecated classic dest docs
Merge timing
asap
Related issues (optional)