Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Library Tiers Description #6917

Merged
merged 4 commits into from
Nov 18, 2024
Merged

Update Library Tiers Description #6917

merged 4 commits into from
Nov 18, 2024

Conversation

prigiattiperrut
Copy link
Contributor

Proposed changes

Added an introductory paragraph to the public documentation to clarify why we have tiers assigned to each library. This addition will help customers understand the criteria for each tier and the rationale behind their assignment.

Merge timing

ASAP once approved

Added an introductory paragraph to the public documentation to clarify why we have tiers assigned to each library. This addition will help customers understand the criteria for each tier and the rationale behind their assignment.
alanjcharles
alanjcharles previously approved these changes Aug 8, 2024
@pwseg pwseg self-requested a review August 8, 2024 16:03
@pwseg pwseg changed the title Update libraries tiers description Update Library Tiers Description Aug 8, 2024
alanjcharles
alanjcharles previously approved these changes Aug 8, 2024
Copy link

netlify bot commented Aug 8, 2024

Deploy Preview for segment-docs ready!

Name Link
🔨 Latest commit 1b27cc7
🔍 Latest deploy log https://app.netlify.com/sites/segment-docs/deploys/673ac22e1ed93d0008c72b0b
😎 Deploy Preview https://deploy-preview-6917--segment-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@forstisabella
Copy link
Contributor

forstisabella commented Aug 8, 2024

Screenshot 2024-08-08 at 12 48 22 PM

looks like the note covers some of the content on the page - could we convert the first sentences to a section in the Source Overview docs and then link to it?

@seg-atlantis-prod
Copy link

Plan Error

running git clone --branch develop --single-branch https://github.com/segmentio/segment-docs.git /home/atlantis/.atlantis/repos/segmentio/segment-docs/6917/default: Cloning into '/home/atlantis/.atlantis/repos/segmentio/segment-docs/6917/default'...
fatal: write error: No space left on device
fatal: fetch-pack: invalid index-pack output
: exit status 128

@pwseg
Copy link
Contributor

pwseg commented Nov 18, 2024

looks like the note covers some of the content on the page - could we convert the first sentences to a section in the Source Overview docs and then link to it?

@forstisabella I like this idea a lot. I removed the new language from tier labels themselves and added them instead as a new section in the Sources overview page.

@pwseg pwseg added the content-update updates to content that are not new features, includes grammar fixes, added notes label Nov 18, 2024
@pwseg pwseg merged commit ec02d82 into develop Nov 18, 2024
3 of 5 checks passed
@pwseg pwseg deleted the prigiattiperrut-patch-6 branch November 18, 2024 04:31
Copy link
Contributor

Thank you for your contribution! Your pull request is merged, but may take a day or two to appear on the site.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content-update updates to content that are not new features, includes grammar fixes, added notes KCS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants