Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Setup guide for StackAdapt audience destination #7221
Setup guide for StackAdapt audience destination #7221
Changes from all commits
3accf62
1febc97
d564735
16f4240
65a9990
be6e8db
e25ea33
fa279f3
c6c8090
9b59611
19ab7f7
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should it say 'Twilio Engage' or 'Segment Engage' here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was changed according to this comment from @forstisabella
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note for Docs team reviewer.
This Destination has 2 Actions.
I'm thinking that might need some specific wording to explain that this Destination the different use-cases for each of these Actions, the different Sources for each (Connections Vs Engage Audience), and the different setup steps for each.
Is this something you can edit into this PR? Or would you like assistance from me or @Vanessa-SSY ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd need the
id
for both actions to add a specific note to the autogenerated Available Actions section of this page. Do you happen to know the id for both actions @joe-ayoub-segment?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @forstisabella :
Forward Audience Event = dkwweyGfhoSh7jWwSi9n4D
Forward Profile = 8mmGRhHeA8F2fzwNXVymNF
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @joe-ayoub-segment & @Vanessa-SSY: I opened a pull request to add in notes for each action. Please approve and merge when you have a minute!
StackAdapt#2
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@forstisabella Thanks! Approved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All changes in this files are result of auto-linter on save
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.