Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sensebox esp32s2 #105

Merged
merged 10 commits into from
Mar 22, 2024
Merged

Add sensebox esp32s2 #105

merged 10 commits into from
Mar 22, 2024

Conversation

mariopesch
Copy link
Member

@mariopesch mariopesch commented Dec 11, 2023

  • add senseBox MCU-S2 as new board
  • add esp32 Board support Package to Dockerfile
  • add some new Libraries

@mariopesch
Copy link
Member Author

@felixerdy do you have any idea why the test is failing?

@mariopesch mariopesch added this to the senseBox MCU-S2 release milestone Jan 26, 2024
closes #108
closes #107
closes #106
@mpfeil
Copy link
Member

mpfeil commented Feb 12, 2024

@mariopesch

Test should reject request with invalid board is failing because https://github.com/sensebox/sensebox-sketches/blob/add-sensebox-esp32s2/test/test.js#L125C11-L125C124 is not equal to the response by the server.
The server response is: Invalid board parameter. Valid values are: sensebox-mcu,sensebox,sensebox-esp32s2
In order to fix this you have to add sensebox-esp32s2 to the test case.

Test should download sketch for senseBox MCU-S2 ESP32S2 is failing because passed board has a typo sensebox_esp32s2 vs sensebox-esp32s2 https://github.com/sensebox/sensebox-sketches/blob/add-sensebox-esp32s2/src/builder.js#L10

@mpfeil
Copy link
Member

mpfeil commented Feb 15, 2024

@mariopesch LGTM. You can merge it.

@mariopesch mariopesch merged commit f8ed71a into main Mar 22, 2024
3 checks passed
@mariopesch mariopesch deleted the add-sensebox-esp32s2 branch March 22, 2024 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants