-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tests / update #121
Merged
Merged
tests / update #121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@felixerdy isn't it bad to use |
Not the most elegant way, I agree. Need to check how we can do it without |
Test Summary - Run #170
🎉 All tests passed! |
Test Summary - Run #171
🎉 All tests passed! |
Refactored to using |
Test Summary - Run #172
🎉 All tests passed! |
test: Run #173
🎉 All tests passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #118
This pull request includes significant updates to the Docker setup, CI workflows, and test configurations. The changes aim to modernize the Docker environment, improve the CI workflow, and enhance the test coverage and reporting.
Dockerfile and Docker Setup Updates:
Dockerfile
tonode:22-alpine
and streamlined environment variable definitions and package installations.arduino-cli lib install --git-url
instead of downloading and unzipping manually.Dockerfile.test
file, consolidating the test and production stages into a singleDockerfile
.CI Workflow Improvements:
.github/workflows/registry-build-publish.yaml
to add atarget: production
parameter for the Docker build action..github/workflows/test.yml
to trigger the workflow only on pull request events for the main branch and added steps to run CTRF annotations. [1] [2]Testing Enhancements:
test/index.js
,test/mcu.js
, andtest/mcu_s2.js
. [1] [2] [3]mocha-reporters.json
configuration file to enable multiple reporters for Mocha, including a custom CTRF JSON reporter.package.json
to include new dev dependencies for Mocha reporters and increased the test timeout. [1] [2]Codebase Improvements:
src/index.js
to conditionally skip logging in test environments.These changes collectively enhance the project's maintainability, testing robustness, and CI/CD efficiency.