Fixed a NullPointerException that occurred during initialization when… #3575
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… using PageFactory
wakaleo
reviewed
Dec 4, 2024
| @@ -95,6 +95,7 @@ private boolean shouldInstrumentField(Field pageObjectField) { | |||
|
|
|||
| private void updatePageObject(Object pageObject) {//, Pages pages) { | |||
| if (pageObject instanceof PageObject) { | |||
| ((PageObject) pageObject).setDriver(Serenity.getWebdriverManager().getWebdriver()); | |||
There was a problem hiding this comment.
This doesn't looks right. You are bypassing the hasAnInstantiatedDriver() test, which may cause problems elsewhere. If you think this is where the problem comes from, you may need to check in that method. Otherwise there may be cases where that method will return null.
Can you add a sample test that reproduces the issue (e.g. in WhenBrowsingAWebSiteUsingPageObjects) and proves that the fix works correctly?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed a NullPointerException that occurred during initialization when using PageFactory