Merge pull request #4347 from serlo/exercise-fixes

quickfix: show exercise task again
serlo · Dec 13, 2024 · 0129a9b · 0129a9b
2 parents 8dc7eb5 + 5cb0ddd
commit 0129a9b
Show file tree

Hide file tree

Showing 3 changed files with 16 additions and 16 deletions.
diff --git a/packages/editor/src/plugins/blanks-exercise/components/blank-check-button.tsx b/packages/editor/src/plugins/blanks-exercise/components/blank-check-button.tsx
@@ -18,7 +18,7 @@ export function BlankCheckButton(props: BlankCheckButtonProps) {
   const isCorrect = [...feedback].every((entry) => entry[1].isCorrect)
 
   return (
-    <div className="mt-2 flex">
+    <div className="mx-side mt-5 flex">
       <button
         className="serlo-button-learner-primary mr-3 h-8"
         onClick={onClick}

diff --git a/packages/editor/src/plugins/blanks-exercise/renderer.tsx b/packages/editor/src/plugins/blanks-exercise/renderer.tsx
@@ -181,7 +181,7 @@ export function BlanksExerciseRenderer({
       <DndWrapper>
         <div
           className={cn(
-            'mx-side mb-block',
+            'mb-block',
             // Increase Slate line height in the editor
             '[&>div>div>div[data-slate-node="element"]]:leading-[30px]',
             // Increase Slate line height in the renderer

diff --git a/packages/editor/src/plugins/exercise/editor.tsx b/packages/editor/src/plugins/exercise/editor.tsx
@@ -88,22 +88,22 @@ export function ExerciseEditor(props: ExerciseProps) {
           </div>
           <div className="h-10"></div>
           <div className="mx-side">
+            {/* Special case for the blanks exercise: Until the child plugin is selected we hide the task to avoid confusion */}
+            {/* Background: Users often add their blanks-text to the task */}
+            <div
+              className={cn(
+                'group-has-[.blanks-child-plugin-selection]/exercise:hidden',
+                '[&_.plugin-rows]:pl-[7px]'
+              )}
+            >
+              {content.render({
+                config: {
+                  textPluginPlaceholder: exStrings.placeholder,
+                },
+              })}
+            </div>
             {interactive.defined ? (
               <>
-                {/* Special case for the blanks exercise: Until the child plugin is selected we hide the task to avoid confusion */}
-                {/* Background: Users often add their blanks-text to the task */}
-                <div
-                  className={cn(
-                    'group-has-[.blanks-child-plugin-selection]/exercise:hidden',
-                    '[&_.plugin-rows]:pl-[7px]'
-                  )}
-                >
-                  {content.render({
-                    config: {
-                      textPluginPlaceholder: exStrings.placeholder,
-                    },
-                  })}
-                </div>
                 {interactive.render()}
                 {hideInteractiveInitially.defined ? (
                   <small className="bg-editor-primary-200 p-1">