refactor: show empty course notice in Entity

serlo · Jan 13, 2025 · 5bec2f8 · 5bec2f8
1 parent a0d27f4
commit 5bec2f8
Show file tree

Hide file tree

Showing 5 changed files with 18 additions and 16 deletions.
diff --git a/apps/web/src/components/entity/entity.tsx b/apps/web/src/components/entity/entity.tsx
@@ -1,6 +1,7 @@
 import {
   EditorPluginType,
   isArticleDocument,
+  isCourseDocument,
   isEmptyArticle,
 } from '@editor/package'
 import {
@@ -43,7 +44,7 @@ export function Entity({ data }: EntityProps) {
   const { strings } = useInstanceData()
   return wrapWithSchema(
     <>
-      {renderNotices()}
+      {renderNotices(data.content)}
       {renderStyledH1()}
       {renderUserTools({ aboveContent: true })}
       <div className="min-h-[25vh]" key={data.id}>
@@ -144,7 +145,7 @@ export function Entity({ data }: EntityProps) {
     )
   }
 
-  function renderNotices() {
+  function renderNotices(document: EntityData['content']) {
     if (data.trashed)
       return (
         <InfoPanel icon={faTrash} doNotIndex>
@@ -180,5 +181,18 @@ export function Entity({ data }: EntityProps) {
         </InfoPanel>
       )
     }
+
+    const isCourse =
+      document &&
+      !Array.isArray(document) &&
+      document.plugin === EditorPluginType.Course &&
+      isCourseDocument(document)
+    if (isCourse && !document.state.pages.length) {
+      return (
+        <InfoPanel icon={faExclamationCircle} type="warning" doNotIndex>
+          {strings.content.courseNoPagesWarning}
+        </InfoPanel>
+      )
+    }
   }
 }
diff --git a/apps/web/src/data/en/index.ts b/apps/web/src/data/en/index.ts
@@ -137,6 +137,8 @@ export const instanceData = {
       picture: 'Picture',
       previewImage: 'Preview Image',
       task: 'Task',
+      courseNoPagesWarning:
+        'Sorry there seem to be no reviewed pages in this course yet.',
     },
     consent: {
       title: 'Consent for external Content',

diff --git a/packages/editor/src/i18n/strings/de/static.ts b/packages/editor/src/i18n/strings/de/static.ts
@@ -40,8 +40,6 @@ export const staticStrings = {
       pages: 'Kursübersicht',
       next: 'Weiter',
       back: 'Zurück',
-      noPagesWarning:
-        'Leider gibt es für diesen Kurs noch keine akzeptierten Seiten.',
       noRevisionForPage: 'Ungegeprüfte Seite',
     },
     exercise: {

diff --git a/packages/editor/src/i18n/strings/en/static.ts b/packages/editor/src/i18n/strings/en/static.ts
@@ -38,8 +38,6 @@ export const staticStrings = {
       pages: 'Course overview',
       next: 'Next',
       back: 'Back',
-      noPagesWarning:
-        'Sorry there seem to be no reviewed pages in this course yet.',
       noRevisionForPage: 'unreviewed page',
     },
     exercise: {

diff --git a/packages/editor/src/plugins/course/static/static.tsx b/packages/editor/src/plugins/course/static/static.tsx
@@ -1,10 +1,7 @@
 import { SerloOnlyFeaturesContext } from '@editor/core/contexts/serlo-only-features-context'
-import { FaIcon } from '@editor/editor-ui/fa-icon'
-import { useStaticStrings } from '@editor/i18n/static-strings-provider'
 import { StaticRenderer } from '@editor/static-renderer/static-renderer'
 import { EditorCourseDocument } from '@editor/types/editor-plugins'
 import { cn } from '@editor/utils/cn'
-import { faExclamationCircle } from '@fortawesome/free-solid-svg-icons'
 import { useState, MouseEvent, useContext } from 'react'
 
 import { CourseFooter } from './course-footer'
@@ -17,7 +14,6 @@ export function CourseStaticRenderer({
 }: EditorCourseDocument) {
   const { pages } = state
 
-  const courseStrings = useStaticStrings().plugins.course
   const { isRevisionView } = useContext(SerloOnlyFeaturesContext)
 
   let asPath = ''
@@ -53,12 +49,6 @@ export function CourseStaticRenderer({
 
   return (
     <>
-      {pages.length ? null : (
-        <div className="my-12 rounded-2xl bg-orange-200 p-4 font-bold">
-          <FaIcon icon={faExclamationCircle} />
-          {courseStrings.noPagesWarning}
-        </div>
-      )}
       <CourseNavigation
         {...state}
         activePageId={activePage?.id}