Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wip: improvements for gleichungs-app #3184

Merged
merged 15 commits into from
Dec 13, 2023

Conversation

Entkenntnis
Copy link
Member

@Entkenntnis Entkenntnis commented Dec 8, 2023

  • setup div for virtual keyboard
  • implement basic keys 0 - 9, komma, =, +-* / (middle section), x, y, a, b, (, ), fraction, moveleft, moveright, enter, delete (remaining as dead keys)
  • connect keyboard to mathfield
  • scroll restoration for overview
  • do some testing on mobile (lower prio)
  • responsive layout for keyboard - reduce key height for smaller keyboards
  • scroll to top after opening new exercise
  • confetti for unlock of level
  • add content for level 6 - level 8

@Entkenntnis Entkenntnis linked an issue Dec 8, 2023 that may be closed by this pull request
@Entkenntnis Entkenntnis marked this pull request as draft December 8, 2023 16:57
Copy link

vercel bot commented Dec 8, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
frontend ✅ Ready (Inspect) Visit Preview Dec 12, 2023 3:30pm

Copy link
Contributor

github-actions bot commented Dec 8, 2023

📦 Next.js Bundle Analysis for @serlo/frontend

This analysis was generated by the Next.js Bundle Analysis action. 🤖

⚠️ Global Bundle Size Increased

Page Size (compressed)
global 103.69 KB (🟡 +231 B)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

One Page Changed Size

The following page changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load
/gleichungs-app 165.07 KB (🟡 +1.08 KB) 268.76 KB
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this.

@Entkenntnis Entkenntnis marked this pull request as ready for review December 12, 2023 15:22
@Entkenntnis Entkenntnis merged commit b7cf085 into staging Dec 13, 2023
11 checks passed
@Entkenntnis Entkenntnis deleted the 3182-improvements-for-gleichungs-app branch December 13, 2023 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

improvements for gleichungs-app
1 participant