Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(e2e): add general tests for mobile #3202

Merged
merged 2 commits into from
Dec 13, 2023
Merged

feat(e2e): add general tests for mobile #3202

merged 2 commits into from
Dec 13, 2023

Conversation

elbotho
Copy link
Member

@elbotho elbotho commented Dec 13, 2023

No description provided.

Copy link

vercel bot commented Dec 13, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
frontend ✅ Ready (Inspect) Visit Preview Dec 13, 2023 0:57am

Copy link
Contributor

📦 Next.js Bundle Analysis for @serlo/frontend

This analysis was generated by the Next.js Bundle Analysis action. 🤖

Sixty-four Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load
/ 85.41 KB (🟡 +30 B) 189.1 KB
/404 38.13 KB (🟡 +30 B) 141.82 KB
/500 38.13 KB (🟡 +30 B) 141.82 KB
/[...slug] 73.31 KB (🟡 +30 B) 177.01 KB
/___ab_dashboard/[id] 39.09 KB (🟡 +30 B) 142.78 KB
/___bot_or_not 90.67 KB (🟡 +30 B) 194.36 KB
/___cf_not_found 36.8 KB (🟡 +30 B) 140.49 KB
/___design 142.15 KB (🟡 +30 B) 245.84 KB
/___editor_preview 475.82 KB (🟡 +30 B) 579.51 KB
/___old_comments 101.61 KB (🟡 +30 B) 205.3 KB
/auth/error 55.66 KB (🟡 +30 B) 159.36 KB
/auth/login 80.62 KB (🟡 +30 B) 184.31 KB
/auth/logout 73.88 KB (🟡 +30 B) 177.58 KB
/auth/oauth/consent 54.24 KB (🟡 +30 B) 157.93 KB
/auth/oauth/login 80.63 KB (🟡 +30 B) 184.32 KB
/auth/oauth/logout 73.89 KB (🟡 +30 B) 177.58 KB
/auth/recovery 62.51 KB (🟡 +30 B) 166.2 KB
/auth/registration 63.45 KB (🟡 +30 B) 167.14 KB
/auth/settings 63.57 KB (🟡 +30 B) 167.26 KB
/auth/verification 62.86 KB (🟡 +30 B) 166.55 KB
/authorization/roles 64.96 KB (🟡 +30 B) 168.65 KB
/backend 38.86 KB (🟡 +30 B) 142.56 KB
/biologie 151.52 KB (🟡 +30 B) 255.21 KB
/chemie 151.52 KB (🟡 +30 B) 255.21 KB
/consent 37.3 KB (🟡 +30 B) 140.99 KB
/content-only/[...slug] 67.58 KB (🟡 +30 B) 171.27 KB
/discussions 96.3 KB (🟡 +30 B) 199.99 KB
/editor 99.48 KB (🟡 +30 B) 203.17 KB
/entity/create/[type]/[taxonomyId] 477.23 KB (🟡 +30 B) 580.92 KB
/entity/license/update/[id] 56.2 KB (🟡 +30 B) 159.89 KB
/entity/link/order/[id]/link 92.76 KB (🟡 +30 B) 196.46 KB
/entity/repository/add-revision/[...id] 476.44 KB (🟡 +30 B) 580.13 KB
/entity/repository/compare/[entity_id]/[revision_id] 100.65 KB (🟡 +30 B) 204.34 KB
/entity/repository/history/[id] 68.83 KB (🟡 +30 B) 172.52 KB
/entity/taxonomy/update/[id] 68.81 KB (🟡 +30 B) 172.5 KB
/entity/unrevised 44.17 KB (🟡 +30 B) 147.86 KB
/event/history 129.48 KB (🟡 +30 B) 233.17 KB
/event/history/[...slug] 133.22 KB (🟡 +30 B) 236.92 KB
/gleichungs-app 165.09 KB (🟡 +30 B) 268.79 KB
/informatik 151.52 KB (🟡 +30 B) 255.22 KB
/jobs/[[...jobId]] 51.26 KB (🟡 +30 B) 154.95 KB
/legal 36.83 KB (🟡 +30 B) 140.53 KB
/lerntipps 151.52 KB (🟡 +30 B) 255.21 KB
/license/detail/[id] 53.23 KB (🟡 +30 B) 156.93 KB
/mathe 151.52 KB (🟡 +30 B) 255.21 KB
/metadata 46.62 KB (🟡 +30 B) 150.31 KB
/nachhaltigkeit 151.53 KB (🟡 +30 B) 255.22 KB
/page/create 476.46 KB (🟡 +30 B) 580.15 KB
/pages 57.54 KB (🟡 +30 B) 161.23 KB
/privacy 40.17 KB (🟡 +30 B) 143.86 KB
/search 41.27 KB (🟡 +30 B) 144.96 KB
/spenden 52.14 KB (🟡 +30 B) 155.83 KB
/subscriptions/manage 111.27 KB (🟡 +30 B) 214.96 KB
/taxonomy/term/[copyOrMove]/batch/[id] 70.6 KB (🟡 +30 B) 174.29 KB
/taxonomy/term/create/[parent_id]/[id] 476.15 KB (🟡 +30 B) 579.84 KB
/taxonomy/term/sort/entities/[id] 95.29 KB (🟡 +30 B) 198.99 KB
/taxonomy/term/update/[id] 476.06 KB (🟡 +30 B) 579.75 KB
/terms 36.85 KB (🟡 +30 B) 140.55 KB
/user/[...userslug] 172.1 KB (🟡 +30 B) 275.8 KB
/user/me 36.63 KB (🟡 +30 B) 140.32 KB
/user/notifications 132.22 KB (🟡 +30 B) 235.91 KB
/user/settings 474.8 KB (🟡 +30 B) 578.49 KB
/uuid/recycle-bin 84.25 KB (🟡 +30 B) 187.94 KB
/wallet 41.89 KB (🟡 +30 B) 145.58 KB
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this.

Copy link
Member

@Entkenntnis Entkenntnis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

nice new feature that while reviewing the PR I can see that the tests where successful

@elbotho elbotho merged commit 6bf198c into staging Dec 13, 2023
13 checks passed
@elbotho elbotho deleted the e2e-mobile branch December 13, 2023 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants