refactor: use editor package in frontend (WIP) #4380
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
📦 Next.js Bundle Analysis for @serlo/frontendThis analysis was generated by the Next.js Bundle Analysis action. 🤖 🎉 Global Bundle Size Decreased
DetailsThe global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster. Any third party scripts you have added directly to your app using the If you want further insight into what is behind the changes, give @next/bundle-analyzer a try! New Page AddedThe following page was added to the bundle from the code in this PR:
Sixty-nine Pages Changed SizeThe following pages changed size from the code in this PR compared to its base branch:
DetailsOnly the gzipped size is provided here based on an expert tip. First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If Any third party scripts you have added directly to your app using the Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this. |
+ rename its file to match context name + move it to editor contexts directory + remove deprecated isSerlo property + update useIsSerlo helper to check for editor variant instead
refactor(web): move strings for uuid-url-input to frontend
refactor: static math in package
refactor(web): duplicate EditorTooltip in frontend
refactor(tests): migrate to vitest, move all tests to editor
Linear issue: EDTR-104
As a first step, all editor imports should point to
'@editor/package'. Then in the end, these can all be replaced by'@serlo/editor'.Current open questions/todos:
Course- Move to Editor fully and replace Next router? -- Try to replace Next router and removeCourseSerloStaticRenderer, but timebox @hejtfulSerloOnlyFeaturesContext? --isSerlodeprecated, export the rest as part of the package @hejtfulstatic-is-emptyand plugin type guards be exported? Maybe as a mapper? Or maybe as a separate package consumed by both Editor and serlo.org? -- export mappers for both as part of the package @hejtfulUuidUrlInputeven used? - Extract the strings it imports out of the editor to remove the editor import @elbothoStaticMath? -- Yes @elbothoEditorTooltipas part of the Editor package? -- Create a Tooltip component for the frontend, should be simpler thanEditorTooltip@elbothoTests to do in the end: