packed writer writes column offsets to meta

Signed-off-by: shaoting-huang <[email protected]>
shaoting-huang · Jan 7, 2025 · ffc3bca · ffc3bca
1 parent 8150e22
commit ffc3bca
Show file tree

Hide file tree

Showing 4 changed files with 2 additions and 64 deletions.
diff --git a/cpp/include/milvus-storage/common/serde.h b/cpp/include/milvus-storage/common/serde.h
@@ -15,7 +15,6 @@
 #pragma once
 #include <arrow/filesystem/filesystem.h>
 #include <string>
-#include <iostream>
 
 namespace milvus_storage {
 
@@ -57,7 +56,6 @@ class PackedMetaSerde {
     }
 
     auto s = ss.str();
-    std::cout << "SerializeColumnOffsets: " << s << std::endl;
     return s;
   }
 

diff --git a/cpp/src/packed/writer.cpp b/cpp/src/packed/writer.cpp
@@ -72,7 +72,6 @@ Status PackedRecordBatchWriter::Write(const std::shared_ptr<arrow::RecordBatch>&
 }
 
 Status PackedRecordBatchWriter::splitAndWriteFirstBuffer() {
-  cout << "start split and write first buffer" << endl;
   auto max_group_size = buffered_batches_[0]->num_columns();
   std::vector<ColumnGroup> groups =
       SizeBasedSplitter(max_group_size, pk_index_, ts_index_).SplitRecordBatches(buffered_batches_);

diff --git a/cpp/test/packed/packed_integration_test.cpp b/cpp/test/packed/packed_integration_test.cpp
@@ -45,20 +45,19 @@ TEST_F(PackedIntegrationTest, TestOneFile) {
 }
 
 TEST_F(PackedIntegrationTest, TestSplitColumnGroup) {
-  int batch_size = 1000;
+  int batch_size = 100000;
 
   std::vector<ColumnOffset> column_offsets = {
       ColumnOffset(0, 0),
+      ColumnOffset(0, 1),
       ColumnOffset(1, 0),
-      ColumnOffset(1, 1),
   };
 
   PackedRecordBatchWriter writer(writer_memory_, schema_, fs_, file_path_, pk_index_, ts_index_, storage_config_);
   for (int i = 0; i < batch_size; ++i) {
     EXPECT_TRUE(writer.Write(record_batch_).ok());
   }
   EXPECT_TRUE(writer.Close().ok());
-  std::cout << "writer closed" << std::endl;
 
   std::vector<std::string> paths = {file_path_ + "/0", file_path_ + "/1"};
 

diff --git a/go/packed/column_offset_mapping.go b/go/packed/column_offset_mapping.go