-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release/3.1.0 #100
Release/3.1.0 #100
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested on Pixel 4a with Android 13, no issues found.
IOS isn't working, 2 testers have reported infinite spinners when loading even after fresh installs. Will need to debug further |
IOS working with build 325 |
@NeOMakinG to take a look at this later today. |
Looks like somewhere along the way we lost the permissions in ios, adding back solved it locally, pushing a build to confirm |
d9915f5#diff-dd86ee93a69fbc92bc90d1c7ea3166b81e5dbb123bcc7426902e3efe6934fc39 we lost permissions in this PR, adding them back seems to resolve the issue |
@gomesalexandre - I looked over that commit a bit and saw we also removed this line d9915f5#diff-dd86ee93a69fbc92bc90d1c7ea3166b81e5dbb123bcc7426902e3efe6934fc39L59 IIRC the intent was to allow the app to update in the background, any reason to not add that back? |
I think all this file has been changed due to a complete rebuild after the udpate We need to bring back every permissions we removed to stay ISO with the old app |
I am adding back a few more items to the info.plist and then will push one last ios build. Mainly just adding the background fetch back and a flag to about encryption to avoid clicking buttons in app store. |
Operations is signing off on the iOS version of this release. QR code scanner working and the app is feeling pretty pretty pretty good. |
IOS and Android Release branch - feel free to add issue discovered during testing here