fix: chain dropdown balance total #8546
Open
+4
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NeOMakinG
requested changes
Jan 13, 2025
There was a problem hiding this comment.
I think this PR can be closed considering that https://github.com/shapeshift/web/pull/8545/files has been merged already, balance seems right now:
vs
|
Right you are @NeOMakinG, this issue was indeed fixed by the upstream PR! Closing. |
|
Actually no, this PR is still necessary. See screenshot below showing this PR (left) and 
|
|
That's very weird, here is how it looks like on this branch:
vs develop: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes the chain dropdown total balance by including staked balances, which the individual chain row balances already include. The total balance is now great (though not again, I don't think it ever was).
Production
This PR
Issue (if applicable)
None, found whilst working on the related #8530
Risk
Small
None
Testing
With a wallet connected that has staking balances, ensure the chain dropdown component (used on the Markets page) shows the correct total balance (the sum of all chain balances).
Engineering
☝️
Operations
☝️
Screenshots (if applicable)
See above.