Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: new wallet flow wcv2 #8616

Draft
wants to merge 2 commits into
base: feat_new_wallet_first_class_2
Choose a base branch
from
Draft

feat: new wallet flow wcv2 #8616

wants to merge 2 commits into from

Conversation

gomesalexandre
Copy link
Contributor

@gomesalexandre gomesalexandre commented Jan 17, 2025 •
edited
Loading

Description

Does what it says on the box - brings wcv2 to new wallet flow

TODO:

  • make it work
  • cleanup
  • composition using same component design as the updated mipd ones

Issue (if applicable)

closes #8593

Risk

High Risk PRs Require 2 approvals

What protocols, transaction types, wallets or contract interactions might be affected by this PR?

Low to none

Testing

Engineering

  • WalletConnect wallet option is happy with the REACT_APP_FEATURE_NEW_WALLET_FLOW flag on
  • WalletConnect wallet option is happy with the REACT_APP_FEATURE_NEW_WALLET_FLOW flag off

Operations

  • 🏁 My feature is behind a flag and doesn't require operations testing (yet)
  • Regression test that WalletConnect wallet option is happy with the REACT_APP_FEATURE_NEW_WALLET_FLOW flag off (i.e what you're testing in this release)

Screenshots (if applicable)

  • Flag on

https://jam.dev/c/381b9f36-3503-450d-850f-0cf4e0b44b6b

  • Flag off

TODO

@gomesalexandre gomesalexandre requested a review from a team as a code owner January 17, 2025 19:18
@gomesalexandre gomesalexandre marked this pull request as draft January 17, 2025 19:18
@gomesalexandre gomesalexandre changed the title [skip ci] wip: new wallet flow wcv2 feat: new wallet flow wcv2 Jan 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@gomesalexandre