Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #146 - Adding a defaultBlockArea #148

Closed
wants to merge 1 commit into from
Closed

Issue #146 - Adding a defaultBlockArea #148

wants to merge 1 commit into from

Conversation

catharsisjelly
Copy link

@catharsisjelly catharsisjelly commented Oct 3, 2017

I remade this to fit v1.1 (which is what I am currently using) but no real reason why it should not work on master too? Fixes #146

As per the other PR, this might be better as a SiteConfig setting so that people can set the default from the options available in the CMS. Let me know if you want to go down that path

Copy link

@WillGibson WillGibson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me @catharsisjelly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants