-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow specific queues to be started independently #68
Open
spencerdcarlson
wants to merge
13
commits into
shinyscorpion:master
Choose a base branch
from
spencerdcarlson:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Manually Launch Specific Queues in an umbrella app
matelau
reviewed
Nov 27, 2018
We should also update the readme with the new configuration options. |
… into single-config
Remove manual_queue_supervisor and use existing TaskBunny.supervisor
Updated README.md
matelau
reviewed
Nov 28, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good 👍
Moved options to Config
I will definitely use this! Can't wait for it to drop. |
@paulstatezny, {:task_bunny,
git: "[email protected]:spencerdcarlson/task_bunny.git", ref: "v1.1.0-sc", runtime: false} |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a manual_queue_supervisor.ex which is a clone of supervisor.ex except it takes an options keyword list as the first parameter.Modified TaskBunny.Supervisor.start_link to take options
The options are eventually passed down to the TaskBunny.WorkerSupervisor where it checks for a list of queue names, or a namespace to start.
Consumers of the task_bunny library can disable runtime dependency which will disable the automatic start of the TaskBunny Application and then call the
TaskBunny.ManualQueuesTaskBunny.Supervisor manually from their umbrella application