-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump dependencies to align with Build v0.12.0 #168
Bump dependencies to align with Build v0.12.0 #168
Conversation
cfd6de0
to
77553e9
Compare
/hold This should wait for #164 to be merged first, as it builds on top of its commits. |
/approve Self-approving |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: adambkaplan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
In preparation of bringing in shipwright-io/build as a dependency, the following dependencies needed to be updated concurrently due to transitive dependencies on k8s.io libraries: - controller-runtime: update to v0.14.6 to align with shipwright-io/build - tektoncd/operator: update to v0.67.0 to align with controller-runtime - k8s.io/* to v0.26.4 (a common patch version) - onsi/ginkgo to v2 (from controller-runtime)
- Utilize ginkgo/v2 SpecContext to handle graceful termination. A separate context was created to isolate EnvTest from any "client" contexts used during tests and avoid deadlocks. - Use v1.26 for EnvTest-driven tests. - Re-generate manifests and bundle
Update KinD to latest released version (v0.20.0) and use the supported v1.24 k8s node version from the corresponding release note. The current Tekton operator on OperatorHub does not support k8s 1.25 or higher. This also sets the minKubeVersion to 1.24.0 on the operator CSV so the version we test with and the min supported version are aligned. See tektoncd/operator#1493.
77553e9
to
eb706b7
Compare
Rebased. Added |
/hold cancel |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Changes
Update the dependencies so we can bring in shipwright-io/build v0.12.0 as a new dependency. This is needed to support #155
Submitter Checklist
See the contributor guide
for details on coding conventions, github and prow interactions, and the code review process.
Release Notes