Source release.yaml from GitHub release #182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pull-request-size
bot
added
the
size/XXL
|
/kind cleanup |
openshift-ci
bot
added
the
kind/cleanup
|
/assign @divyansh42 |
1 task
The `release.yaml` used as the base for deploying Shipwright Builds appears to have been manipulated by a YAML linter or other processor. There are significant differentes in YAML structure and formatting between the `kodata/release.yaml` in tree and the `release.yaml` published on GitHub for the respective release (v0.12.0). This makes it difficult to verify that the operator is deploying the right thing, especially when versions are bumped. This replaces the `kodata/release.yaml` in tree with the `release.yaml` published for v0.12.0. This will make it easy to verify that we are deploying the right version of Shipwright Builds with the operator, as well as support future workflows that let contributors update the deployed operand from a nightly release. Signed-off-by: Adam Kaplan <[email protected]>
adambkaplan
force-pushed
the
source-release-from-gh
branch
from
0ad82a2 to
ca57c83
Compare
In the v0.12.0 `release.yaml`, the Build API webhook has a cluster role that grants it '*' permission on many core resources. This is technically different from the original RBAC deployed in the operator's modified `release.yaml`, which itemized the supported verbs for the webhook. This commit adds the '*' verb permission for these resources, which are then needed to deploy all content in `release.yaml`. The OLM bundle was regenerated so that the RBAC is granted to the operator via the `ClusterServiceVersion` definition. Note that the use of '*' permissions in Kubernetes RBAC is highly discouraged, as it violates the principle of least privilege. A more narrowly scoped RBAC for the build webhook should be provided in a future release. Signed-off-by: Adam Kaplan <[email protected]>
4 tasks
|
/assign @ayushsatyam146 |
|
/cc @SaschaSchwarze0 Note - this is not directly tied to the v0.13.0 release. My goal here is to set a good "baseline" so when we upgrade to v0.13.0, it is easier to see what changed. |
|
The diff for Below is the more relevant diff at the top of the file, everything else is formatting or CRD related: |
|
/lgtm |
|
/approve Self-approving as this PR has been out for a while, and we want this to land before updating |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: adambkaplan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
The
release.yamlused as the base for deploying Shipwright Builds appears to have been manipulated by a YAML linter or other processor. There are significant differentes in YAML structure and formatting between thekodata/release.yamlin tree and therelease.yamlpublished on GitHub for the respective release (v0.12.0). This makes it difficult to verify that the operator is deploying the right thing, especially when versions are bumped.This replaces the
kodata/release.yamlin tree with therelease.yamlpublished for v0.12.0. This will make it easy to verify that we are deploying the right version of Shipwright Builds with the operator, as well as support future workflows that let contributors update the deployed operand from a nightly release.Fixes #184
Submitter Checklist
See the contributor guide
for details on coding conventions, github and prow interactions, and the code review process.
Release Notes