Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NEXT-36303 - In app purchases #27

Merged
merged 58 commits into from
Dec 2, 2024
Merged

Conversation

lernhart
Copy link
Member

No description provided.

@lernhart lernhart force-pushed the next-36303/feature/in-app-purchases branch from 0c99aed to e0eb057 Compare August 15, 2024 12:34
@codecov-commenter
Copy link

codecov-commenter commented Aug 15, 2024

Codecov Report

Attention: Patch coverage is 77.27273% with 50 lines in your changes missing coverage. Please review.

Project coverage is 71.20%. Comparing base (1294c2c) to head (39801ea).

Files with missing lines Patch % Lines
...nistration/src/module/sw-in-app-purchases/index.ts 0.00% 12 Missing ⚠️
...-app-purchases/service/in-app-purchases.service.ts 0.00% 9 Missing ⚠️
src/Services/InAppPurchasesService.php 0.00% 8 Missing ⚠️
src/Services/StoreClient.php 87.50% 6 Missing ⚠️
src/Controller/InAppPurchasesController.php 90.56% 5 Missing ⚠️
...sion-store-in-app-purchases-listing-modal/index.js 0.00% 3 Missing ⚠️
...sion-store/page/sw-extension-store-detail/index.js 60.00% 2 Missing ⚠️
...ses/component/sw-in-app-purchase-checkout/index.ts 95.91% 2 Missing ⚠️
...inistration/src/module/sw-extension-store/index.js 0.00% 1 Missing ⚠️
...xtension/component/sw-extension-card-base/index.ts 66.66% 1 Missing ⚠️
... and 1 more
Additional details and impacted files
@@             Coverage Diff              @@
##              trunk      #27      +/-   ##
============================================
+ Coverage     69.42%   71.20%   +1.78%     
- Complexity       39       63      +24     
============================================
  Files            22       34      +12     
  Lines           749      969     +220     
  Branches        107      125      +18     
============================================
+ Hits            520      690     +170     
- Misses          200      250      +50     
  Partials         29       29              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Bird87ZA Bird87ZA force-pushed the next-36303/feature/in-app-purchases branch from 9bebe52 to 4fa6c4f Compare August 29, 2024 07:06
@Bird87ZA Bird87ZA force-pushed the next-36303/feature/in-app-purchases branch 3 times, most recently from 7210547 to e7b1849 Compare October 1, 2024 10:11
@Bird87ZA Bird87ZA force-pushed the next-36303/feature/in-app-purchases branch from d099e35 to bda6d8f Compare November 29, 2024 07:07
@cyl3x cyl3x requested a review from seggewiss November 29, 2024 08:03
@cyl3x
Copy link
Contributor

cyl3x commented Nov 29, 2024

Hey @seggewiss, can you have a look at the written admin components to see if they are more or less well written? 😄

@Bird87ZA Bird87ZA force-pushed the next-36303/feature/in-app-purchases branch from c3b979e to fc0d67e Compare November 29, 2024 13:10
@Bird87ZA Bird87ZA requested review from mstegmeyer and cyl3x November 29, 2024 13:10
@Bird87ZA Bird87ZA force-pushed the next-36303/feature/in-app-purchases branch from 825f925 to 3007417 Compare November 29, 2024 14:01
@Bird87ZA Bird87ZA force-pushed the next-36303/feature/in-app-purchases branch from 1a13de5 to ccd376e Compare November 29, 2024 14:36
@Bird87ZA Bird87ZA requested a review from cyl3x November 29, 2024 14:38
@Bird87ZA Bird87ZA merged commit 362dd7b into trunk Dec 2, 2024
6 checks passed
@Bird87ZA Bird87ZA deleted the next-36303/feature/in-app-purchases branch December 2, 2024 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants