[chore] Add logs and metrics k8s attributes verification tests #1610
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pszkamruk-splunk
changed the title
atoulme
reviewed
Jan 13, 2025
| return resourceAttributes, notFoundCounter | ||
| } | ||
|
|
||
| func getMetricsResourceAttribute(metrics []pmetric.Metrics, attributeName string) ([]string, int) { |
There was a problem hiding this comment.
you're checking on a metric attribute, not a resource attribute
Suggested change
| func getMetricsResourceAttribute(metrics []pmetric.Metrics, attributeName string) ([]string, int) { | |
| func getMetricsAttribute(metrics []pmetric.Metrics, attributeName string) ([]string, int) { |
There was a problem hiding this comment.
@atoulme my understanding of what I am checking here is probably incorrect. I thought I am checking in these tests resourceAttributes, but actually I am checking logs/metrics attributes. Should I update the variables and function names from resourceAttributes to logs/metricsAttributes, getLogsResourceAttribute to getLogsAttribute, etc.?
There was a problem hiding this comment.
yes, it's misleading otherwise
There was a problem hiding this comment.
renaming done
pszkamruk-splunk
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: Adding resource attributes tests to ensure that events and metrics are enriched with additional k8s attributes
Testing: additional tests
Documentation: N/A