Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change installer flag to use --with[out]-instrumentation-sdk #3841

Merged
merged 14 commits into from
Oct 30, 2023

Conversation

atoulme
Copy link
Contributor

@atoulme atoulme commented Oct 24, 2023

Description:
Instead of using flags per language, condense the instrumentation SDK selection using a --with[out]-instrumentation-sdk flag.

@atoulme atoulme requested review from a team as code owners October 24, 2023 20:54
@atoulme atoulme force-pushed the change_installer_flag branch 2 times, most recently from 7c72a90 to 0aba2d1 Compare October 24, 2023 21:34
@atoulme atoulme force-pushed the change_installer_flag branch from 0aba2d1 to 5aee1b4 Compare October 24, 2023 21:40
Copy link
Contributor

@pjanotti pjanotti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with 1 Q and 2 minor suggestions.

internal/buildscripts/packaging/installer/install.sh Outdated Show resolved Hide resolved
internal/buildscripts/packaging/installer/install.sh Outdated Show resolved Hide resolved
@atoulme atoulme merged commit d6c47db into main Oct 30, 2023
92 checks passed
@delete-merged-branch delete-merged-branch bot deleted the change_installer_flag branch October 30, 2023 22:23
@github-actions github-actions bot locked and limited conversation to collaborators Oct 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants