-
Notifications
You must be signed in to change notification settings - Fork 158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change installer flag to use --with[out]-instrumentation-sdk
#3841
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atoulme
force-pushed
the
change_installer_flag
branch
2 times, most recently
from
October 24, 2023 21:34
7c72a90
to
0aba2d1
Compare
atoulme
force-pushed
the
change_installer_flag
branch
from
October 24, 2023 21:40
0aba2d1
to
5aee1b4
Compare
pjanotti
approved these changes
Oct 24, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with 1 Q and 2 minor suggestions.
Co-authored-by: Paulo Janotti <[email protected]>
Co-authored-by: Paulo Janotti <[email protected]>
jinja2
reviewed
Oct 24, 2023
pjanotti
approved these changes
Oct 25, 2023
Co-authored-by: Jeff Cheng <[email protected]>
Co-authored-by: Jeff Cheng <[email protected]>
Co-authored-by: Jeff Cheng <[email protected]>
Co-authored-by: Jeff Cheng <[email protected]>
Co-authored-by: Jeff Cheng <[email protected]>
Co-authored-by: Jeff Cheng <[email protected]>
Co-authored-by: Jeff Cheng <[email protected]>
Co-authored-by: Jeff Cheng <[email protected]>
Co-authored-by: Jeff Cheng <[email protected]>
rmfitzpatrick
approved these changes
Oct 27, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Instead of using flags per language, condense the instrumentation SDK selection using a
--with[out]-instrumentation-sdk
flag.