Remove use of deprecated code and defaults in config #3956
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atoulme
force-pushed
the
remove_use_of_deprecated_code
branch
from
4cb03bd to
d2740e5
Compare
pjanotti
reviewed
Nov 29, 2023
crobert-1
reviewed
Nov 29, 2023
| @@ -218,7 +218,6 @@ type CollectdConfig struct { | |||
| // If you won't be using any collectd monitors, this can be set to true to | |||
| // prevent collectd from pre-initializing | |||
| DisableCollectd bool `yaml:"disableCollectd" default:"false"` | |||
| // Deprecated: this setting has no effect and will be removed. | |||
There was a problem hiding this comment.
Why are we removing the deprecated notices here?
(This might be a duplicate of @pjanotti's question, so feel free to ignore if that's the case)
There was a problem hiding this comment.
Because I made a mistake. While this code has no usage in go, it is serialized to represent collectd config on disk, and removing it breaks tests. I should not have deprecated it in the first place.
crobert-1
approved these changes
Nov 29, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will unblock #3954: it removes the use of deprecated code. As part of this removal, I have removed the defaults set on the field so they are no longer interpreted and tests no longer need to refer to them.