Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add discovery mode #5781

Merged
merged 17 commits into from
Jan 15, 2025
Merged

Add discovery mode #5781

merged 17 commits into from
Jan 15, 2025

Conversation

hughesjj
Copy link
Contributor

@hughesjj hughesjj commented Jan 11, 2025

Only tested linux, windows is done via orca

@hughesjj hughesjj force-pushed the add_discovery_mode branch 25 times, most recently from 4e3af66 to 6c72130 Compare January 14, 2025 22:48
@hughesjj hughesjj marked this pull request as ready for review January 15, 2025 00:17
@hughesjj hughesjj requested review from a team as code owners January 15, 2025 00:17
Copy link
Contributor

@atoulme atoulme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a couple nits

@hughesjj hughesjj merged commit 4c4fda7 into signalfx:main Jan 15, 2025
6 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jan 15, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants