Drop unused settings (#416)

signalfx · Feb 7, 2024 · 04f3284 · 04f3284
1 parent 4d6fd43
commit 04f3284
Show file tree

Hide file tree

Showing 4 changed files with 0 additions and 95 deletions.
diff --git a/src/Splunk.OpenTelemetry.AutoInstrumentation/Configuration/ConfigurationExtensions.cs b/src/Splunk.OpenTelemetry.AutoInstrumentation/Configuration/ConfigurationExtensions.cs
diff --git a/src/Splunk.OpenTelemetry.AutoInstrumentation/ConfigurationKeys.cs b/src/Splunk.OpenTelemetry.AutoInstrumentation/ConfigurationKeys.cs
@@ -67,15 +67,5 @@ public static class OpenTelemetry
         /// Configuration key for OTLP endpoint.
         /// </summary>
         public const string OtlpEndpoint = "OTEL_EXPORTER_OTLP_ENDPOINT";
-
-        /// <summary>
-        /// Configuration key for service name.
-        /// </summary>
-        public const string ServiceName = "OTEL_SERVICE_NAME";
-
-        /// <summary>
-        /// Configuration key for resource attributes.
-        /// </summary>
-        public const string ResourceAttributes = "OTEL_RESOURCE_ATTRIBUTES";
     }
 }
diff --git a/src/Splunk.OpenTelemetry.AutoInstrumentation/PluginSettings.cs b/src/Splunk.OpenTelemetry.AutoInstrumentation/PluginSettings.cs
@@ -34,11 +34,9 @@ internal PluginSettings(IConfigurationSource source)
 
         Realm = source.GetString(ConfigurationKeys.Splunk.Realm) ?? Constants.None;
         AccessToken = source.GetString(ConfigurationKeys.Splunk.AccessToken);
-        ServiceName = source.GetString(ConfigurationKeys.OpenTelemetry.ServiceName);
         TraceResponseHeaderEnabled = source.GetBool(ConfigurationKeys.Splunk.TraceResponseHeaderEnabled) ?? true;
         var otlpEndpoint = source.GetString(ConfigurationKeys.OpenTelemetry.OtlpEndpoint);
         IsOtlpEndpointSet = !string.IsNullOrEmpty(otlpEndpoint);
-        ResourceAttributes = source.GetString(ConfigurationKeys.OpenTelemetry.ResourceAttributes).ToNameValueCollection();
 
 #if NET6_0_OR_GREATER
         CpuProfilerEnabled = source.GetBool(ConfigurationKeys.Splunk.AlwaysOnProfiler.CpuProfilerEnabled) ?? false;
@@ -54,14 +52,10 @@ internal PluginSettings(IConfigurationSource source)
 
     public string? AccessToken { get; }
 
-    public string? ServiceName { get; }
-
     public bool TraceResponseHeaderEnabled { get; }
 
     public bool IsOtlpEndpointSet { get; }
 
-    public IReadOnlyCollection<KeyValuePair<string, string>> ResourceAttributes { get; }
-
 #if NET6_0_OR_GREATER
     public bool CpuProfilerEnabled { get; }
 

diff --git a/test/Splunk.OpenTelemetry.AutoInstrumentation.Tests/ConfigurationExtensionsTests.cs b/test/Splunk.OpenTelemetry.AutoInstrumentation.Tests/ConfigurationExtensionsTests.cs