Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Continuous profiler - Splunk exporter #393

Merged
merged 35 commits into from
Jan 11, 2024
Merged

Conversation

Kielek
Copy link
Contributor

@Kielek Kielek commented Dec 21, 2023

Relays on changes from open-telemetry/opentelemetry-dotnet-instrumentation#3196

It is a port of profiler-exporter from https://github.com/signalfx/signalfx-dotnet-tracing
It brings Vendored version of protobuf-net.

The test is focus on testing the exporter. The frames detected by the native code (Vb, F#, C++) are tested in the upstream.

Tested with local build (both, upstream and the Splunk plugin). For now, there is no possibility to execute tests in CI.

Follow ups:

  1. Verify if we can drop protobuf-net and relay only on the same libraries as OpenTelemetry.Exporter.OpenTelemetryProtocol.
  2. Add test for allocation sampling (it is not available in the SFx version).
  3. Update upstream to work it in CI/in release.

Notes

While merging, please add following comment:

Co-authored-by: John Bley <[email protected]>
Co-authored-by: Paulo Janotti <[email protected]>
Co-authored-by: Robert Pająk <[email protected]>
Co-authored-by: Mateusz Łach <[email protected]>
Co-authored-by: Dawid Szmigielski <[email protected]>

@Kielek Kielek changed the title [draft] Continuous profiler - Splunk exporter Continuous profiler - Splunk exporter Jan 2, 2024
@Kielek Kielek marked this pull request as ready for review January 2, 2024 10:44
@Kielek Kielek requested review from a team as code owners January 2, 2024 10:44
@Kielek Kielek enabled auto-merge (squash) January 11, 2024 06:04
@Kielek Kielek merged commit 929edf3 into signalfx:main Jan 11, 2024
10 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jan 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants