Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop unused settings #416

Merged
merged 2 commits into from
Feb 7, 2024
Merged

Drop unused settings #416

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1ca539f
Drop unused settings
Kielek Feb 7, 2024
218e10f
Drop unused helper classes
Kielek Feb 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 0 additions & 10 deletions src/Splunk.OpenTelemetry.AutoInstrumentation/ConfigurationKeys.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,15 +67,5 @@ public static class OpenTelemetry
/// Configuration key for OTLP endpoint.
/// </summary>
public const string OtlpEndpoint = "OTEL_EXPORTER_OTLP_ENDPOINT";

/// <summary>
/// Configuration key for service name.
/// </summary>
public const string ServiceName = "OTEL_SERVICE_NAME";

/// <summary>
/// Configuration key for resource attributes.
/// </summary>
public const string ResourceAttributes = "OTEL_RESOURCE_ATTRIBUTES";
}
}
6 changes: 0 additions & 6 deletions src/Splunk.OpenTelemetry.AutoInstrumentation/PluginSettings.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,11 +34,9 @@ internal PluginSettings(IConfigurationSource source)

Realm = source.GetString(ConfigurationKeys.Splunk.Realm) ?? Constants.None;
AccessToken = source.GetString(ConfigurationKeys.Splunk.AccessToken);
ServiceName = source.GetString(ConfigurationKeys.OpenTelemetry.ServiceName);
TraceResponseHeaderEnabled = source.GetBool(ConfigurationKeys.Splunk.TraceResponseHeaderEnabled) ?? true;
var otlpEndpoint = source.GetString(ConfigurationKeys.OpenTelemetry.OtlpEndpoint);
IsOtlpEndpointSet = !string.IsNullOrEmpty(otlpEndpoint);
ResourceAttributes = source.GetString(ConfigurationKeys.OpenTelemetry.ResourceAttributes).ToNameValueCollection();

#if NET6_0_OR_GREATER
CpuProfilerEnabled = source.GetBool(ConfigurationKeys.Splunk.AlwaysOnProfiler.CpuProfilerEnabled) ?? false;
Expand All @@ -54,14 +52,10 @@ internal PluginSettings(IConfigurationSource source)

public string? AccessToken { get; }

public string? ServiceName { get; }

public bool TraceResponseHeaderEnabled { get; }

public bool IsOtlpEndpointSet { get; }

public IReadOnlyCollection<KeyValuePair<string, string>> ResourceAttributes { get; }

#if NET6_0_OR_GREATER
public bool CpuProfilerEnabled { get; }

Expand Down
Loading