-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: replace integration-tests karma with playwright #887
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Joozty
force-pushed
the
chore/playwright
branch
from
November 7, 2024 12:53
6681f24
to
a16b260
Compare
Joozty
force-pushed
the
chore/playwright
branch
from
November 7, 2024 12:54
a16b260
to
0efe05a
Compare
Joozty
force-pushed
the
chore/playwright
branch
from
November 7, 2024 12:57
0efe05a
to
68b4baa
Compare
Joozty
force-pushed
the
chore/playwright
branch
from
November 7, 2024 12:59
68b4baa
to
302cacf
Compare
Joozty
force-pushed
the
chore/playwright
branch
from
November 7, 2024 13:20
302cacf
to
83081a2
Compare
Joozty
force-pushed
the
chore/playwright
branch
from
November 7, 2024 14:24
11d29c0
to
e2bbabf
Compare
Joozty
force-pushed
the
chore/playwright
branch
from
November 7, 2024 14:25
e2bbabf
to
8548593
Compare
Joozty
force-pushed
the
chore/playwright
branch
from
November 7, 2024 14:33
8548593
to
38e9a1b
Compare
Joozty
force-pushed
the
chore/playwright
branch
from
November 7, 2024 14:44
38e9a1b
to
0a34c0c
Compare
Joozty
force-pushed
the
chore/playwright
branch
from
December 5, 2024 14:21
cf59284
to
eb941ec
Compare
Joozty
force-pushed
the
chore/playwright
branch
from
December 5, 2024 14:59
eb941ec
to
eabe17b
Compare
Joozty
force-pushed
the
chore/playwright
branch
from
December 10, 2024 12:38
eabe17b
to
b9e10e2
Compare
Joozty
force-pushed
the
chore/playwright
branch
from
December 10, 2024 12:56
b9e10e2
to
4b85a21
Compare
Joozty
force-pushed
the
chore/playwright
branch
from
December 11, 2024 10:49
840c3bf
to
740d9ae
Compare
Joozty
changed the title
chore: replace karma with playwright
chore: replace integration-tests karma with playwright
Dec 11, 2024
amertak
approved these changes
Dec 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
GJ!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The main goal is to replace Karma, which is deprecated, with Playwright and migrate the tests to TypeScript. I aimed to keep the API the same or with minimal changes. With these updates, we’ll be able to run the Edge browser in CI without using Sauce Labs.
Type of change
Delete options that are not relevant.
How has this been tested?
Delete options that are not relevant.
N/A