Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add Python 3.12 #801

Merged
merged 5 commits into from
Oct 18, 2023
Merged

ci: add Python 3.12 #801

merged 5 commits into from
Oct 18, 2023

Conversation

woodruffw
Copy link
Member

Chore; adds 3.12 to our test matrix.

Signed-off-by: William Woodruff <[email protected]>
@woodruffw woodruffw requested a review from di October 17, 2023 20:59
@woodruffw woodruffw self-assigned this Oct 17, 2023
@woodruffw
Copy link
Member Author

. env/bin/activate && \
	 pytest --cov-append --cov=sigstore test/unit --skip-online -vv --showlocals && \
	python -m coverage report -m 
ImportError while loading conftest '/home/runner/work/sigstore-python/sigstore-python/test/unit/conftest.py'.
test/unit/conftest.py:32: in <module>
    from sigstore_protobuf_specs.dev.sigstore.bundle.v1 import Bundle
env/lib/python3.12/site-packages/sigstore_protobuf_specs/dev/sigstore/bundle/v1/__init__.py:7: in <module>
    import betterproto
env/lib/python3.12/site-packages/betterproto/__init__.py:39: in <module>
    from ._version import __version__
env/lib/python3.12/site-packages/betterproto/_version.py:1: in <module>
    from pkg_resources import get_distribution
E   ModuleNotFoundError: No module named 'pkg_resources'
make: *** [Makefile:82: test] Error 4

From a quick look, it looks like betterproto depends on pkg_resources, and we depend on betterproto via sigstore-protobuf-specs.

Looks like a fix was released with 2.0.0b6: danielgtaylor/python-betterproto#462

Will get this fixed in sigstore-protobuf-specs.

@woodruffw
Copy link
Member Author

Upstream fix: sigstore/protobuf-specs#151

@woodruffw woodruffw enabled auto-merge (squash) October 18, 2023 15:48
@woodruffw
Copy link
Member Author

This should be good to go now -- sigstore-protobuf-specs has been bumped and now works correctly with 3.12.

@woodruffw woodruffw merged commit 9a73e91 into main Oct 18, 2023
23 checks passed
@woodruffw woodruffw deleted the ww/py312 branch October 18, 2023 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants