FIX Don't include installer for non-modules #89
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GuySartorelli
force-pushed
the
pulls/1.14/no-installer-for-cow
branch
from
715250d to
9eb226a
Compare
GuySartorelli
commented
May 8, 2024
Comment on lines
-138
to
+148
| ['myaccount/recipe-cms', '4', ''], | ||
| ['myaccount/recipe-cms', '4.10', ''], | ||
| ['myaccount/recipe-cms', 'burger', ''], | ||
| ['myaccount/recipe-cms', 'pulls/4/myfeature', ''], | ||
| ['myaccount/recipe-cms', 'pulls/4.10/myfeature', ''], | ||
| ['myaccount/recipe-cms', 'pulls/burger/myfeature', ''], | ||
| ['myaccount/recipe-cms', '5', ''], | ||
| ['myaccount/recipe-cms', '5.1', ''], | ||
| ['myaccount/recipe-cms', '6', ''], | ||
| ['myaccount/recipe-cms', '6.0', ''], | ||
| 'recipe-cms1' => ['myaccount/recipe-cms', '4', ''], | ||
| 'recipe-cms2' => ['myaccount/recipe-cms', '4.10', ''], | ||
| 'recipe-cms3' => ['myaccount/recipe-cms', 'burger', ''], | ||
| 'recipe-cms4' => ['myaccount/recipe-cms', 'pulls/4/myfeature', ''], | ||
| 'recipe-cms5' => ['myaccount/recipe-cms', 'pulls/4.10/myfeature', ''], | ||
| 'recipe-cms6' => ['myaccount/recipe-cms', 'pulls/burger/myfeature', ''], | ||
| 'recipe-cms7' => ['myaccount/recipe-cms', '5', ''], | ||
| 'recipe-cms8' => ['myaccount/recipe-cms', '5.1', ''], | ||
| 'recipe-cms9' => ['myaccount/recipe-cms', '6', ''], | ||
| 'recipe-cms10' => ['myaccount/recipe-cms', '6.0', ''], |
There was a problem hiding this comment.
Adding keys to these and others below was to make it easier to see what was failing while debugging this PR - I decided to keep these in so future debugging is similarly easy
GuySartorelli
commented
May 8, 2024
tests/JobCreatorTest.php
Outdated
Comment on lines
191
to
201
| // random third-party repo | ||
| 'random1' => ['myaccount/my-module', '4.0', '', [['name' => '6']], ['silverstripe/framework' => '^6']], | ||
| 'random2' => ['myaccount/my-module', '4.0', '6.x-dev', [['name' => '6']], ['silverstripe/framework' => '^6'], 'silverstripe-module'], | ||
| 'random3' => ['myaccount/my-module', '4.0', '6.x-dev', [['name' => '6']], ['silverstripe/framework' => '^6'], 'silverstripe-vendormodule'], | ||
| 'random4' => ['myaccount/my-module', '4.0', '6.x-dev', [['name' => '6']], ['silverstripe/framework' => '^6'], 'silverstripe-recipe'], | ||
| 'random5' => ['myaccount/my-module', '4.0', '6.x-dev', [['name' => '6']], ['silverstripe/framework' => '^6'], 'silverstripe-theme'], | ||
| 'random6' => ['myaccount/my-module', '4.0', '', [['name' => '6']]], |
There was a problem hiding this comment.
Testing that the type of package does matter - regular repos don't have any type, and so they don't get installer.
GuySartorelli
force-pushed
the
pulls/1.14/no-installer-for-cow
branch
from
9eb226a to
78acf55
Compare
emteknetnz
requested changes
May 8, 2024
GuySartorelli
force-pushed
the
pulls/1.14/no-installer-for-cow
branch
from
78acf55 to
678b5b3
Compare
emteknetnz
approved these changes
May 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks like I got this the wrong way around - if we have any data in the repositories.json file for a repo, we were adding installer for it (even if it shouldn't have installer)!
Now we're only adding installer for repos which need it - either because they explicitly need it, or because we can see from their composer package type that they're a Silverstripe CMS module
Issue