Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A NN parameterization to test in the neverworld framework #18

Draft
wants to merge 34 commits into
base: main
Choose a base branch
from

Conversation

simone-silvestri
Copy link
Owner

This PR adds a NN closure to the neverworld representing the subgrid-scale fluxes of unrepresented mesoscale eddies in the large-scale circulation.

To be tested with a grid-size of 1/4 or 1/2 of a degree.
The neural network (provided by @Etienne-Meunier) uses values from https://github.com/chzhangudel/Forpy_CNN_GZ21/blob/smartsim/testNN.py

PR in collaboration with
@Etienne-Meunier and @vopikamm

@glwagner
Copy link
Collaborator

glwagner commented Jun 24, 2024

@xkykai, why don't you improve Oceananigans' RiBasedVerticalDiffusivity?

@simone-silvestri
Copy link
Owner Author

cc @xkykai

@xkykai
Copy link
Collaborator

xkykai commented Jun 24, 2024

@simone-silvestri should this be the nonlocal Ri-based parameterization that we have implemented? Let me retrain the model with varying Prandtl number in positive and negative Ri regimes then I can incorporate this.

@glwagner
Copy link
Collaborator

@simone-silvestri should this be the nonlocal Ri-based parameterization that we have implemented? Let me retrain the model with varying Prandtl number in positive and negative Ri regimes then I can incorporate this.

It looks like you have an improvement to the current RiBasedVerticalDiffusivity, right? We want the best model, whatever that is

@xkykai
Copy link
Collaborator

xkykai commented Jun 24, 2024

Yes I have, let me retrain with some slight modifications then I'll put it in!

@xkykai
Copy link
Collaborator

xkykai commented Jun 25, 2024

@simone-silvestri could you add me as a collaborator? I have updated the XinKaiVerticalDiffusivity with new parameter values as well as allowing 2 different turbulent prandtl numbers in convective and shear-driven regime, but I have no permission to push. It has also been calibrated against heating and precipitation scenarios. This scheme will preserve shear better than the current one.

@simone-silvestri
Copy link
Owner Author

@xkykai I added you as a collaborator, but I think the idea was to add this parameterization directly to Oceananigans (not here) and to remove the parameterization from here.

I think the idea is to modify the formulation and parameters RiBasedVerticalDiffusivity since this parameterization is basically the same in spirit with some minor changes in the functional form of the diffusivity and viscosity and in the parameters

@xkykai
Copy link
Collaborator

xkykai commented Jun 25, 2024

Okay, in practice that means renaming XinKaiVerticalDiffusivity into RiBasedVerticalDiffusivity right? Should I open a draft PR in Oceananigans to do that then?

Also do you think we should still keep the original RiBasedVerticalDiffusivity instead of modifying it? I feel like there might be merits in keeping it since it might have some advantages compared to the one I have right now.

@glwagner
Copy link
Collaborator

Okay, in practice that means renaming XinKaiVerticalDiffusivity into RiBasedVerticalDiffusivity right? Should I open a draft PR in Oceananigans to do that then?

Also do you think we should still keep the original RiBasedVerticalDiffusivity instead of modifying it? I feel like there might be merits in keeping it since it might have some advantages compared to the one I have right now.

What is the difference? They seem very similar, can they be implemented within a common framework using simple abstractions?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants