Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(browsers): fix panic when version compare fail #9

Merged
merged 1 commit into from
Dec 26, 2024

Conversation

joelwurtz
Copy link
Contributor

@joelwurtz joelwurtz commented Nov 13, 2024

I did not recall why exactly, but i have done this update in our forked repository as we were having a panic here in some user agent string (unfortunetaly i did not keep the user agent string responsible for this panic)

However it avoid a expect and simply ignore this error if it happens

@mindreader
Copy link
Contributor

Nice catch.

@vanetix
Copy link
Contributor

vanetix commented Dec 26, 2024

Thanks for this!

@vanetix vanetix merged commit 349f82a into simplecastapps:main Dec 26, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants