-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
vendor(deps): bump github.com/stretchr/testify from 1.9.0 to 1.10.0 #1
Closed
dependabot
wants to merge
1
commit into
main
from
dependabot/go_modules/github.com/stretchr/testify-1.10.0
Closed
vendor(deps): bump github.com/stretchr/testify from 1.9.0 to 1.10.0 #1
dependabot
wants to merge
1
commit into
main
from
dependabot/go_modules/github.com/stretchr/testify-1.10.0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bumps [github.com/stretchr/testify](https://github.com/stretchr/testify) from 1.9.0 to 1.10.0. - [Release notes](https://github.com/stretchr/testify/releases) - [Commits](stretchr/testify@v1.9.0...v1.10.0) --- updated-dependencies: - dependency-name: github.com/stretchr/testify dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
dependabot
bot
added
dependencies
Pull requests that update a dependency file
go
Pull requests that update Go code
labels
Dec 1, 2024
fho
added a commit
that referenced
this pull request
Dec 2, 2024
After a PR that is first in the queue is suspended, run the CI jobs for the PR that was promoted to be #1 in the active queue.
fho
added a commit
that referenced
this pull request
Dec 9, 2024
The following loop can happen where a PR changes state from being #1 in the queue to being suspended: - CI jobs are alraedy running for a PR, that becomes #1 in the queue, - CI jobs are triggered, >=1 job is configured to abort previous running builds when a new one is triggered, aborting the builds generates a failed github status check event, - updates for the PR are suspended because of the failed CI status, - The new queued build starts to run, a check notification is received that the CI job is in pending status again. - updates for the PR are resumed, which triggers the CI jobs again, => the loop starts from the beginning again Prevent that it happes by: - storing per PR when the last time CI jobs have been successfully triggered and for which HEAD commit, - only trigger CI job runs when it is for the same HEAD commit when it was triggered last longer than 15min ago,
Looks like github.com/stretchr/testify is up-to-date now, so this is no longer needed. |
dependabot
bot
deleted the
dependabot/go_modules/github.com/stretchr/testify-1.10.0
branch
December 16, 2024 11:35
fho
added a commit
that referenced
this pull request
Dec 18, 2024
If a PR has been suspended multiple times it is likely that CI jobs for it are failing because of an issue in the branch. Process PRs with a higher SuspendCount but the same priority after ones with a lower SuspendCount. This reduces how often a PR becomes #1 in the queue when CI jobs always fail for it and the base branch is often updated causing it to be added again to the active queue.
fho
added a commit
that referenced
this pull request
Jan 14, 2025
When a Pullrequest is #1 in the queue, all it's required CI checks are successful and the required number of approvals is reached a successful Github Status state is now submitted for the head commit. The context of the status is "directorius". When a PR is suspended or removed from the queue and it has not been merged the Status is set to pending. On startup the status is set to pending for for all head commits of PRs that are open and have a successful status state. (This resets the status on startup.) Github can be configured to only automerge a PR when the directorius state is successful. This results in only merging PRs that are #1 in the mergequeue.
fho
added a commit
that referenced
this pull request
Jan 14, 2025
Return the pull request by ListPRs in ascending updated order. This has the effect that on directorius startup the PR that has been updated the longest time ago will become #1 instead of a random PR.
fho
added a commit
that referenced
this pull request
Jan 15, 2025
A successful github status is only submitted when the overall CIStatus for the PR is successful. When Github is configured to require the successful directorius status as merge requirement, the condition can never be satisfied. The overall CI status is pending without the directorius state and it is not submitted because the status is not successful. Submit the successful CI status for the #1 PR in the queue when it's status is pending or successful.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
0 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumps github.com/stretchr/testify from 1.9.0 to 1.10.0.
Release notes
Sourced from github.com/stretchr/testify's releases.
... (truncated)
Commits
89cbdd9
Merge pull request #1626 from arjun-1/fix-functional-options-diff-indirect-calls07bac60
Merge pull request #1667 from sikehish/flaky716de8d
Increase timeouts in Test_Mock_Called_blocks to reduce flakiness in CI118fb83
NotSame should fail if args are not pointers #1661 (#1664)7d99b2b
attempt 205f87c0
more similarea7129e
better fmta1b9c9e
Merge pull request #1663 from ybrustin/master8302de9
Merge branch 'master' into master89352f7
Merge pull request #1518 from hendrywiranto/adjust-readme-remove-v2Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase
.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebase
will rebase this PR@dependabot recreate
will recreate this PR, overwriting any edits that have been made to it@dependabot merge
will merge this PR after your CI passes on it@dependabot squash and merge
will squash and merge this PR after your CI passes on it@dependabot cancel merge
will cancel a previously requested merge and block automerging@dependabot reopen
will reopen this PR if it is closed@dependabot close
will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditions
will show all of the ignore conditions of the specified dependency@dependabot ignore this major version
will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor version
will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependency
will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)