Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Go sisimai compatibility 7e8a #314

Merged
merged 24 commits into from
Nov 25, 2024
Merged

Conversation

azumakuniyuki
Copy link
Member

@azumakuniyuki azumakuniyuki commented Nov 24, 2024

  • Import commits from sisimai/go-sisimai in October 2024
  • Implement Sisimai::RFC1123
  • Remove redundant codes from Sisimai::Lhost::GMX
  • Remove useless condition from Sisimai::Lhost::Gmail
  • Code improvement in Sisimai::Lhost::GoogleGroups
  • Update error message patterns in Sisimai::Lhost::IMailServer
  • Variable name changed in Sisimai::Lhost::KDDI
  • Remove redundant codes for getting error messages from Sisimai::Lhost::MailFoundry
  • Remove the unused variable from Sisimai::Lhost::McAfee
  • Improved code for getting the recipient address in Sisimai::Lhost::MessagingServer
  • Remove useless condition from Sisimai::Lhost::OpenSMTPD
  • Replace SMTP command names with the lowercased name in Sisimai::Lhost::qmail
  • Update error message patterns for Suspend reason in Sisimai::Lhost::qmail
  • Sisimai::Reason.get() has been renamed to find()

Copy link

codecov bot commented Nov 24, 2024

Codecov Report

Attention: Patch coverage is 97.97980% with 2 lines in your changes missing coverage. Please review.

Project coverage is 95.01%. Comparing base (9c4a184) to head (480bb2e).
Report is 25 commits behind head on 5-stable.

Files with missing lines Patch % Lines
lib/sisimai/fact.rb 87.50% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##           5-stable     #314      +/-   ##
============================================
+ Coverage     95.00%   95.01%   +0.01%     
============================================
  Files           135      136       +1     
  Lines          6783     6806      +23     
============================================
+ Hits           6444     6467      +23     
  Misses          339      339              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@azumakuniyuki azumakuniyuki merged commit f94d83c into 5-stable Nov 25, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant