virt/incus: Fix buildimage and run scripts #317
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theCalcaholic
force-pushed
the
master
branch
from
e127dfc to
ea8000f
Compare
theCalcaholic
force-pushed
the
master
branch
from
ea8000f to
d37e6c8
Compare
|
Lgtm! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unfortunately I missed a few typos in the scripts. Also, the check for the incus command is now unnecessary in the buildimage script, because it only creates the archive and doesn't actually import it yet, so I removed that (that's for example relevant for my use case where I build in a different container than I use to run the incus container).
The new versions of the scripts are now verified working. Sorry for the inconvenience.