VisionFive2: Replace custom uboot with latest version #321
Conversation
| # source: https://github.com/starfive-tech/u-boot/tree/JH7110_VisionFive2_devel | ||
| # 59cf9af678dbfa3d73f6cb86ed1ae7219da9f5c9 | ||
| BR2_TARGET_UBOOT_CUSTOM_TARBALL_LOCATION="$(call github,starfive-tech,u-boot,ac0ac696256abf412826d74ee918dd417e207d7b)/u-boot-visionfive2-ac0ac6-r2.tar.gz" | ||
| BR2_TARGET_UBOOT_LATEST_VERSION=y |
There was a problem hiding this comment.
Could we set a specific version instead of LATEST? I usually do that to avoid random breakages when updating buildroot. This way someone can update it when needed and test to make sure the new version works properly before committing.
There was a problem hiding this comment.
@maxberger I think you still have latest version set here as well as the custom version. Probably need to delete this line - LATEST_VERSION
| BR2_TARGET_OPENSBI_PLAT="generic" | ||
| BR2_TARGET_OPENSBI_UBOOT_PAYLOAD=n | ||
| BR2_TARGET_OPENSBI_FW_FDT_PATH=y | ||
| BR2_TARGET_OPENSBI_CUSTOM_TARBALL=n |
There was a problem hiding this comment.
Please use the is not set comment syntax instead of =n for consistency
Support for visionfive2 has been in mainline uboot for a while. Signed-off-by: Max Berger <[email protected]>
Comments addressed. |
| # source: https://github.com/starfive-tech/u-boot/tree/JH7110_VisionFive2_devel | ||
| # 59cf9af678dbfa3d73f6cb86ed1ae7219da9f5c9 | ||
| BR2_TARGET_UBOOT_CUSTOM_TARBALL_LOCATION="$(call github,starfive-tech,u-boot,ac0ac696256abf412826d74ee918dd417e207d7b)/u-boot-visionfive2-ac0ac6-r2.tar.gz" | ||
| BR2_TARGET_UBOOT_LATEST_VERSION=y |
There was a problem hiding this comment.
@maxberger I think you still have latest version set here as well as the custom version. Probably need to delete this line - LATEST_VERSION
| # BR2_TARGET_OPENSBI_UBOOT_PAYLOAD is not set | ||
| BR2_TARGET_OPENSBI_FW_FDT_PATH=y | ||
| # BR2_TARGET_OPENSBI_CUSTOM_TARBALL is not set | ||
| BR2_TARGET_OPENSBI_LATEST_VERSION=y |
There was a problem hiding this comment.
Is it possible to pin opensbi to a specific version too? (Not critical)
|
Okay this is all good, will merge now. |
Support for visionfive2 has been in mainline uboot for a while.