docs(be): re-write admin problem module api docs #1296
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
- prisma 접근 코드에 await 처리 안되어있는 부분 수정 - docs 에러코드 작성
SH9480P
reviewed
Feb 4, 2024
collection/admin/Problem/Update ContestProblems Order/NOT_FOUND.bru
Outdated
Show resolved
Hide resolved
collection/admin/Problem/Update WorkbookProblems Order/Succeed.bru
Outdated
Show resolved
Hide resolved
collection/admin/Problem/Update WorkbookProblems Order/NOT_FOUND.bru
Outdated
Show resolved
Hide resolved
|
저도 assert 보완 / Input 관련 상세설명 추가만 되면 좋을 것 같습니다~ |
- 새롭게 정해진 convention에 따라 args를 설명하는 표 삭제
cho-to
added a commit
that referenced
this pull request
Feb 19, 2024
* docs(be): re-write admin problem module api docs * fix(be): add missing await - prisma 접근 코드에 await 처리 안되어있는 부분 수정 - docs 에러코드 작성 * docs(be): modify assert option * docs(be): delete args table - 새롭게 정해진 convention에 따라 args를 설명하는 표 삭제 * docs(be): modify assert * fix(be): apply http error * docs(be): modify api docs Co-authored-by: cho-to <[email protected]> Co-authored-by: SH9480P <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #1264
Admin Problem 모듈의 api docs를 새로운 api docs convention에 맞춰 재작성합니다.
Additional context
일부 예외 처리 로직이 잘못되어UNPROCESSABLE또는NOT_FOUND로 표시되어야 하는데INTERNAL_SERVER_ERROR로 표시되는 문제가 있습니다. 이 경우 일단 assert에 error code를 추가해놓지 않았고, 문제 수정 후 추가할 예정입니다.=> 수정했습니다
Before submitting the PR, please make sure you do the following
fixes #123).