Skip to content

Commit

Permalink
Clean up variables in Makefile
Browse files Browse the repository at this point in the history
The variables that are defined in the Makefile
are by default set to false. A contributor
needs to always overwrite them via CLI, it
does not matter if they are present in the
Makefile or not.

Current behavior has a limitation that if
someone does not want to always overwrite
them via CLI and they export those variables
in a terminal session - it would have no effect
effect since the values for those variables are
hard-coded in the Makefile.

Signed-off-by: Michal Šoltis <[email protected]>
  • Loading branch information
slimreaper35 committed Oct 17, 2024
1 parent 6a0d5a7 commit 7eddec2
Showing 1 changed file with 2 additions and 10 deletions.
12 changes: 2 additions & 10 deletions Makefile
Original file line number Diff line number Diff line change
@@ -1,9 +1,4 @@
PYTHON_VERSION_VENV ?= python3
TOX_ENVLIST ?= py3
TOX_ARGS ?=
GENERATE_TEST_DATA = false
TEST_LOCAL_PYPISERVER = false
TEST_LOCAL_DNF_SERVER = false

.PHONY: clean pip-compile
all: venv
Expand All @@ -22,13 +17,10 @@ test: venv
venv/bin/tox

test-unit: venv
venv/bin/tox -e $(TOX_ENVLIST) -- $(TOX_ARGS)
venv/bin/tox -e py3

test-integration: venv
CACHI2_GENERATE_TEST_DATA=$(GENERATE_TEST_DATA) \
CACHI2_TEST_LOCAL_PYPISERVER=$(TEST_LOCAL_PYPISERVER) \
venv/bin/tox -e integration -- $(TOX_ARGS)
CACHI2_TEST_LOCAL_DNF_SERVER=$(TEST_LOCAL_DNF_SERVER)
venv/bin/tox -e integration

mock-unittest-data:
hack/mock-unittest-data/gomod.sh
Expand Down

0 comments on commit 7eddec2

Please sign in to comment.