Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add property to toggle anti-aliasing on Path elements #7308

Merged
merged 3 commits into from
Jan 10, 2025

Conversation

tronical
Copy link
Member

@tronical tronical commented Jan 9, 2025

This enables working around bugs in GPU drivers. Especially the GC7000UL
plus its driver on imx8mp has been observed to sometimes horribly degrade in performance when Skia renders anti-aliased paths (when a function like gcoSURF_BlitCPU shows up at the top of perf that's a bad sign).

This enables working around bugs in GPU drivers. Especially the GC7000UL
plus its driver on imx8mp has been observed to sometimes horribly degrade in
performance when Skia renders anti-aliased paths (when a function like
`gcoSURF_BlitCPU` shows up at the top of `perf` that's a bad sign).
@tronical tronical force-pushed the simon/path-antialias-option branch from 051700b to 1ba7e73 Compare January 9, 2025 13:15
@ogoffart
Copy link
Member

ogoffart commented Jan 9, 2025

I wonder if one could reuse the image-rendering enum here.
But I guess the name is different.
Imone thought I had is to extend the enum with a "default" that would be the default so the software renderer could default to pixelated. That's not possible with a bool

@tronical
Copy link
Member Author

tronical commented Jan 9, 2025

I wonder if one could reuse the image-rendering enum here. But I guess the name is different.

Yeah, same conclusion here. Different fit/purpose. image-rendering affects how the image is rendered when scaled, while this is about the Path rendering, regardless of the size.

@tronical tronical merged commit c764da4 into master Jan 10, 2025
37 checks passed
@tronical tronical deleted the simon/path-antialias-option branch January 10, 2025 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants