Add more CI testing and fix R4 generation #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikix
commented
Jul 12, 2024
Comment on lines
-612
to
+616
| if prop.enum is not None: | ||
| if prop.enum is not None and not self.spec.class_name_is_native(prop_cls_name): |
There was a problem hiding this comment.
This is the bit that fixes AccountStatus.str being used instead of str
- Add CI generation test for R5 - Add CI unit test for R4 - Fix a generation bug that wrote out bogus enum classes like AccountStatus.str instead of just str - Fix an R5 generation bug by adding enum mappings for + and - - Change the default unit test filename pattern from _tests.py to _test.py so that pytest automatically finds the files - Fix a unit-test generation bug that didn't properly escape backslashes in strings - Generate models/__init__.py automatically so that all the relative importing the models do works out of the box R5 unit tests still don't pass with this commit, but that can be left to a future effort. R4 is still the default generation mode.
mikix
changed the title
dogversioning
approved these changes
Jul 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
models/__init__.pyautomatically so that all the relative importing the models do works out of the boxR5 unit tests still don't pass with this commit, but that can be left to a future effort. R4 is still the default generation mode.
Fixes: #44
Fixes: #28