Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support PSR-based network transports #22

Draft
wants to merge 11 commits into
base: main
Choose a base branch
from
Draft

Support PSR-based network transports #22

wants to merge 11 commits into from

Conversation

Firehed
Copy link
Contributor

@Firehed Firehed commented Aug 15, 2024

Allows use of PSRs 17 and 18 as an alternative to the default cURL transport.

Fixes #21.

Copy link

codecov bot commented Aug 15, 2024

Codecov Report

Attention: Patch coverage is 3.22581% with 60 lines in your changes missing coverage. Please review.

Project coverage is 28.31%. Comparing base (1f69757) to head (269b282).

Files Patch % Lines
src/Transport/Curl.php 0.00% 34 Missing ⚠️
src/Transport/Psr.php 0.00% 20 Missing ⚠️
src/Client.php 28.57% 5 Missing ⚠️
src/Transport/Response.php 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main      #22      +/-   ##
============================================
- Coverage     35.29%   28.31%   -6.98%     
- Complexity       16       21       +5     
============================================
  Files             4        7       +3     
  Lines            85      113      +28     
============================================
+ Hits             30       32       +2     
- Misses           55       81      +26     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow providing a PSR-18 HTTP client (or just timeout controls?)
1 participant