Merge pull request #182 from graben/jms

Add default value for JMS pool name to reduce needed configuration for proper registration in Narayana
snowdrop · Jan 7, 2025 · f5c700b · f5c700b
2 parents eb2e51a + 84e7c5f
commit f5c700b
Show file tree

Hide file tree

Showing 7 changed files with 2 additions and 8 deletions.
diff --git a/...a/dev/snowdrop/boot/narayana/core/properties/MessagingHubConnectionFactoryProperties.java b/...a/dev/snowdrop/boot/narayana/core/properties/MessagingHubConnectionFactoryProperties.java
@@ -20,8 +20,8 @@
 
 public class MessagingHubConnectionFactoryProperties {
 
-    private boolean enabled;
-    private String name;
+    private boolean enabled = false;
+    private String name = "jms";
     private int maxConnections = 1;
     private Duration connectionIdleTimeout = Duration.ofSeconds(30);
     private Duration connectionCheckInterval = Duration.ofMillis(-1);

diff --git a/...ing-boot-starter-it/src/test/java/dev/snowdrop/boot/narayana/pooled/PooledRecoveryIT.java b/...ing-boot-starter-it/src/test/java/dev/snowdrop/boot/narayana/pooled/PooledRecoveryIT.java
@@ -26,7 +26,6 @@
  */
 @SpringBootTest(classes = TestApplication.class, properties = {
     "narayana.messaginghub.enabled=true",
-    "narayana.messaginghub.name=jms",
     "spring.datasource.agroal.flushOnClose=true",
     "spring.datasource.generateUniqueName=false",
     "spring.datasource.name=jdbc"

diff --git a/...arter-it/src/test/java/dev/snowdrop/boot/narayana/testcontainers/DB2PooledRecoveryIT.java b/...arter-it/src/test/java/dev/snowdrop/boot/narayana/testcontainers/DB2PooledRecoveryIT.java
@@ -32,7 +32,6 @@
 @Testcontainers
 @SpringBootTest(classes = TestApplication.class, properties = {
         "narayana.messaginghub.enabled=true",
-        "narayana.messaginghub.name=jms",
         "spring.datasource.agroal.flushOnClose=true",
         "spring.datasource.generateUniqueName=false",
         "spring.datasource.name=jdbc",

diff --git a/...ter-it/src/test/java/dev/snowdrop/boot/narayana/testcontainers/MSSQLPooledRecoveryIT.java b/...ter-it/src/test/java/dev/snowdrop/boot/narayana/testcontainers/MSSQLPooledRecoveryIT.java
@@ -33,7 +33,6 @@
 @Testcontainers
 @SpringBootTest(classes = TestApplication.class, properties = {
     "narayana.messaginghub.enabled=true",
-    "narayana.messaginghub.name=jms",
     "spring.datasource.generateUniqueName=false",
     "spring.datasource.name=jdbc"
 })

diff --git a/...ter-it/src/test/java/dev/snowdrop/boot/narayana/testcontainers/MySQLPooledRecoveryIT.java b/...ter-it/src/test/java/dev/snowdrop/boot/narayana/testcontainers/MySQLPooledRecoveryIT.java
@@ -30,7 +30,6 @@
 @Testcontainers
 @SpringBootTest(classes = TestApplication.class, properties = {
     "narayana.messaginghub.enabled=true",
-    "narayana.messaginghub.name=jms",
     "spring.datasource.generateUniqueName=false",
     "spring.datasource.name=jdbc"
 })

diff --git a/...er-it/src/test/java/dev/snowdrop/boot/narayana/testcontainers/OraclePooledRecoveryIT.java b/...er-it/src/test/java/dev/snowdrop/boot/narayana/testcontainers/OraclePooledRecoveryIT.java
@@ -31,7 +31,6 @@
 @Testcontainers
 @SpringBootTest(classes = TestApplication.class, properties = {
     "narayana.messaginghub.enabled=true",
-    "narayana.messaginghub.name=jms",
     "spring.datasource.generateUniqueName=false",
     "spring.datasource.name=jdbc"
 })

diff --git a/...t/src/test/java/dev/snowdrop/boot/narayana/testcontainers/PostgreSQLPooledRecoveryIT.java b/...t/src/test/java/dev/snowdrop/boot/narayana/testcontainers/PostgreSQLPooledRecoveryIT.java
@@ -30,7 +30,6 @@
 @Testcontainers
 @SpringBootTest(classes = TestApplication.class, properties = {
     "narayana.messaginghub.enabled=true",
-    "narayana.messaginghub.name=jms",
     "spring.datasource.generateUniqueName=false",
     "spring.datasource.name=jdbc"
 })