Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SNOW-859635: Retry Strategy #671

Merged
merged 29 commits into from
Oct 27, 2023
Merged

SNOW-859635: Retry Strategy #671

merged 29 commits into from
Oct 27, 2023

Conversation

sfc-gh-ext-simba-jy
Copy link
Collaborator

@sfc-gh-ext-simba-jy sfc-gh-ext-simba-jy commented Oct 19, 2023 •
edited
Loading

Description

Please explain the changes you made here.

  • Drivers will be updated to have their version number in the header.
  • Add a new Jitter rule ( I am not sure that I can use the old jitter I have)
  • Change the login max times.

Checklist

  • Format code according to the existing code style (run npm run lint:check -- CHANGED_FILES and fix problems in changed code)
  • Create tests which fail without the change (if possible)
  • Make all tests (unit and integration) pass (npm run test:unit and npm run test:integration)
  • Extend the README / documentation and ensure is properly displayed (if necessary)
  • Provide JIRA issue id (if possible) or GitHub issue id in commit message

@sfc-gh-ext-simba-jy sfc-gh-ext-simba-jy changed the title Retry Strategy SNOW-859635: Retry Strategy Oct 19, 2023
sfc-gh-ext-simba-lf
sfc-gh-ext-simba-lf reviewed Oct 23, 2023
View reviewed changes
lib/util.js Outdated Show resolved Hide resolved
sfc-gh-ext-simba-lf
sfc-gh-ext-simba-lf reviewed Oct 23, 2023
View reviewed changes
lib/util.js Outdated Show resolved Hide resolved
sfc-gh-ext-simba-lf
sfc-gh-ext-simba-lf reviewed Oct 23, 2023
View reviewed changes
lib/util.js Outdated Show resolved Hide resolved
@sfc-gh-ext-simba-jy sfc-gh-ext-simba-jy marked this pull request as ready for review October 24, 2023 01:30
@sfc-gh-ext-simba-jy sfc-gh-ext-simba-jy requested a review from a team as a code owner October 24, 2023 01:30
sfc-gh-pmotacki
sfc-gh-pmotacki approved these changes Oct 24, 2023
View reviewed changes
lib/util.js Outdated Show resolved Hide resolved
lib/util.js Outdated Show resolved Hide resolved
lib/connection/connection_config.js Outdated Show resolved Hide resolved
sfc-gh-pmotacki
sfc-gh-pmotacki requested changes Oct 24, 2023
View reviewed changes
Copy link
Collaborator

@sfc-gh-pmotacki sfc-gh-pmotacki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I propose something to change

sfc-gh-pmotacki
sfc-gh-pmotacki requested changes Oct 26, 2023
View reviewed changes
lib/connection/connection_config.js Outdated Show resolved Hide resolved
lib/util.js Outdated Show resolved Hide resolved
@sfc-gh-ext-simba-jy sfc-gh-ext-simba-jy merged commit cf17fa0 into master Oct 27, 2023
42 checks passed
@sfc-gh-ext-simba-jy sfc-gh-ext-simba-jy deleted the retrystrategy branch October 27, 2023 19:57
@github-actions github-actions bot locked and limited conversation to collaborators Oct 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sfc-gh-pmotacki sfc-gh-pmotacki sfc-gh-pmotacki approved these changes

@sfc-gh-ext-simba-lf sfc-gh-ext-simba-lf sfc-gh-ext-simba-lf left review comments

@sfc-gh-dheyman sfc-gh-dheyman Awaiting requested review from sfc-gh-dheyman

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sfc-gh-ext-simba-jy @sfc-gh-ext-simba-lf @sfc-gh-pmotacki @sfc-gh-dheyman