Add experimental fetch repetition field value implementation #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add GenericCollectionFieldMetadata to handle '@MaxRepetitions', $Type 'Collection(Edm.String)' ...
DASPRiD
requested changes
Apr 4, 2023
| @@ -238,8 +238,9 @@ class Connection { | |||
| const cleanedJson = json.replace(/"(?:(?=(\\?))\1.)*?"/gs, substring => { | |||
| return substring.replace(/(?<!\\)((?:\\\\)*)\n/g, '$1\\n'); | |||
| }); | |||
| const tabCleanedJson = cleanedJson.replace(/\t/g, '\\t'); | |||
There was a problem hiding this comment.
Do you have an example response coming from FileMaker where this is an issue in the parsing process?
If it is, it should be handled in the regexp above to avoid escaping tabs which are outside of JSON strings.
|
|
||
| public async fetchBinaryFieldValue(id : PrimaryKey, fieldName : string, repetition ?: number) : Promise<Blob> { | ||
| let path : string; | ||
| if (repetition === undefined) |
| describe('fetchFieldValue', () => { | ||
| it('should return the result', async () => { | ||
| databaseStub.fetchJson.returns(Promise.resolve({})); | ||
| await table.fetchFieldValue('bar', 'baz'); |
There was a problem hiding this comment.
Missing assertion on the return type.
| ); | ||
| }); | ||
|
|
||
| it('should return the result', async () => { |
There was a problem hiding this comment.
These two tests have the same description – should be updated to clarify their difference.
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.