Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add vite 6 compatible devtools #156

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

birkskyum
Copy link
Contributor

@birkskyum birkskyum commented Dec 27, 2024

The devtools has become compatible with Vite 6, so they can be added to the templates again.

For the typings to work in vite.config, the tsconfig has to be set to use module: bundler

@atilafassina
Copy link
Member

After reading up on NodeNext vs Bundler I'm a bit wary of setting oru templates to moduleResolution: "bundler".

In enabling both kinds of import it make things harder to tree-shake, don't you think?

This may cause issues specially in SolidStart apps. Perhaps enforcing an ESM-only approach is best while we can add a note to the docs that changing to "bundler" would be supported in certain specific scenarios where there's no way around it.

@birkskyum
Copy link
Contributor Author

birkskyum commented Dec 28, 2024

@thetarnav was it trivial to add back the types version so the existing modules resolution "node" would work? I think module resolution "node" is mentioned as deprecated in newer node versions, so it's probably best to move on anyways, and we do use a bundler... Don't know the difference between node next - think there's a requirement to use file extension in imports with NodeNext

@thetarnav
Copy link
Contributor

Yeah I can revert easily.
But switching to "bundler" as a default would be a better default.
There are other packages that also don't support the "node" module resolution anymore: rhysd/remark-emoji#28 (comment)

thetarnav added a commit to thetarnav/solid-devtools that referenced this pull request Dec 29, 2024
@thetarnav
Copy link
Contributor

thetarnav commented Jan 4, 2025

I added typesVersions back so changing tsconfig settings here shouldn't be necessary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants