Improve access edge collection performance #2258
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aquamatthias
requested changes
Dec 30, 2024
| @@ -271,7 +262,7 @@ def get_last_run() -> Optional[datetime]: | |||
| log.warning(f"Unexpected node type {node} in graph") | |||
| raise Exception("Only AWS resources expected") | |||
|
|
|||
| access_edge_collection_enabled = os.environ.get("ACCESS_EDGE_COLLECTION_ENABLED", "false").lower() == "true" | |||
| access_edge_collection_enabled = False | |||
There was a problem hiding this comment.
This basically disables the functionality always. Let's use it this way:
- Remove this flag
- config defaults to false
- The config property has a warning as a description.
If someone wants to turn it on, it must be enabled in the configuration with clear documentation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
To-Dos
toxsuccessfully.Code of Conduct
By submitting this pull request, I agree to follow the code of conduct.